fix: lock CI to macOS 14 #1278
Open
fix: lock CI to macOS 14 #1278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
full context: quickjs-ng#1172 (comment)
There was a problem hiding this comment.
Pull request overview
This PR locks the macOS runner version to macOS 14 in the release workflow to address a specific issue (referenced in GitHub issue #1172). The change replaces macos-latest with macos-14 to ensure consistent behavior in release builds.
- Pins the macOS runner to a specific version (14) instead of using the floating
latesttag
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| macos: | ||
| runs-on: macos-latest | ||
| runs-on: macos-14 |
There was a problem hiding this comment.
This change locks the macOS runner to version 14, but the ci.yml workflow still uses macos-latest in multiple places (lines 500, 532, 557, 666, 673, 695, 704, 707, 720, 723, 727, 739). If the issue referenced in the PR affects macOS runners, consider whether ci.yml should also be updated for consistency to avoid similar issues in CI runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
full context: #1172 (comment)