Draft
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds resource tagging functionality across AWS resources for better cost tracking and resource management in Quilt stacks.
- Added
common_tagsandstack_dependent_tagsin/modules/quilt/locals.tfto standardize tag structure - Critical issue: Empty
stack_dependent_tagsinitialization in both/modules/db/main.tfand/modules/search/main.tfprevents proper tag propagation - Added comprehensive tag testing framework in
/testsdirectory to verify tag behavior - Accidentally committed temporary Terraform files (
.terraform.tfstate.lock.info) that should be gitignored - Missing CHANGELOG entry for tracking these changes
11 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
modules/search/main.tf
Outdated
Comment on lines
1
to
3
| locals { | ||
| stack_dependent_tags = {} | ||
| } |
There was a problem hiding this comment.
logic: Empty tags map will not propagate parent module's stack-dependent tags. Should receive tags as a variable or inherit from parent module.
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
… add-cost-tags
There was a problem hiding this comment.
Pull Request Overview
This PR adds cost tags functionality by standardizing tag structure and introducing new tests to verify tagging behavior on AWS resources. Key changes include:
- Adding common_tags and stack_dependent_tags in the Quilt module for Terraform.
- Introducing a comprehensive test framework under the /tests directory.
- Providing documentation in tests/README.md on how to execute the tests.
Reviewed Changes
Copilot reviewed 4 out of 13 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test.yml | Provides a minimal CloudFormation template for testing. |
| tests/README.md | Documents the test prerequisites and steps. |
Files not reviewed (9)
- modules/db/main.tf: Language not supported
- modules/db/variables.tf: Language not supported
- modules/quilt/locals.tf: Language not supported
- modules/quilt/main.tf: Language not supported
- modules/quilt/outputs.tf: Language not supported
- modules/search/main.tf: Language not supported
- modules/search/variables.tf: Language not supported
- tests/.terraform.lock.hcl: Language not supported
- tests/test_tags.tf: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Companion to https://github.com/quiltdata/deployment/pull/2042
Match id and stack name for Terraform-created resources
TODO