move sudo to outside execute of system_requirements_internal#279
Open
lz100 wants to merge 3 commits intor-lib:mainfrom
lz100:master
Open
move sudo to outside execute of system_requirements_internal#279lz100 wants to merge 3 commits intor-lib:mainfrom lz100:master
execute of system_requirements_internal#279lz100 wants to merge 3 commits intor-lib:mainfrom
lz100:master
Conversation
jimhester
reviewed
Mar 3, 2021
Co-authored-by: Jim Hester <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we just want to print out the command with
sudobut does not want to execute the command,current 'pak' does not prepend "sudo" unless you combine
execute = TRUE, e.g## [1] "apt-get install -y libssl-dev"This pull request moves
sudooutsideexecute, so whensudo = TRUE, execute = FALSE, thesudowill still be prepend tooutput.