Skip to content

Fix system tests for RabbitMQ 3.13.x#2162

Merged
Zerpet merged 1 commit into
mainfrom
fix/rabbitmq-313-system-tests
Jun 12, 2026
Merged

Fix system tests for RabbitMQ 3.13.x#2162
Zerpet merged 1 commit into
mainfrom
fix/rabbitmq-313-system-tests

Conversation

@Zerpet

@Zerpet Zerpet commented Jun 11, 2026

Copy link
Copy Markdown
Member

Summary

  • Increase memory allocation from 700Mi to 1Gi to support RabbitMQ 3.13.x which requires more memory out of the box
  • Improve system test helpers with Ginkgo best practices for cleaner and more reliable test execution

Changes

  • Memory Allocation: Increased memory requests and limits from 700Mi to 1Gi in 3 test locations to accommodate RabbitMQ 3.13.x requirements
  • Resource Management: Removed explicit channel close in AMQPS publisher to reduce resource pressure during tests
  • Test Improvements:
    • Use GinkgoHelper() for proper error reporting in test helper functions
    • Change EventuallyWithOffset to return error instead of bool for cleaner error handling
    • Fix ExpectWithOffset offset values in nested callbacks
    • Replace defer GinkgoRecover() with GinkgoHelper() for consistency

Test Plan

  • Run system tests against RabbitMQ 3.13.x cluster to verify tests pass with increased memory allocation
  • Check that test output is cleaner and more readable with Ginkgo improvements

Made with Cursor

- Increase memory allocation from 700Mi to 1Gi to support RabbitMQ 3.13.x which requires more memory
- Remove explicit channel close in AMQPS publisher to reduce resource pressure
- Improve MQTT and Stream message handlers with Ginkgo best practices:
  - Use GinkgoHelper() for proper test output and error reporting
  - Change EventuallyWithOffset to return error instead of bool for cleaner error handling
  - Fix ExpectWithOffset offset values in nested callbacks
  - Replace defer GinkgoRecover() with GinkgoHelper() for consistency

Fixes system test failures when running against RabbitMQ 3.13.x clusters.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Zerpet Zerpet force-pushed the fix/rabbitmq-313-system-tests branch from a63658d to 3e025ae Compare June 12, 2026 07:52
@Zerpet Zerpet added this to the v2.22.0 milestone Jun 12, 2026
@Zerpet Zerpet merged commit bc7592e into main Jun 12, 2026
78 of 79 checks passed
@Zerpet Zerpet deleted the fix/rabbitmq-313-system-tests branch June 12, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants