Fix system tests for RabbitMQ 3.13.x#2162
Merged
Merged
Conversation
- Increase memory allocation from 700Mi to 1Gi to support RabbitMQ 3.13.x which requires more memory - Remove explicit channel close in AMQPS publisher to reduce resource pressure - Improve MQTT and Stream message handlers with Ginkgo best practices: - Use GinkgoHelper() for proper test output and error reporting - Change EventuallyWithOffset to return error instead of bool for cleaner error handling - Fix ExpectWithOffset offset values in nested callbacks - Replace defer GinkgoRecover() with GinkgoHelper() for consistency Fixes system test failures when running against RabbitMQ 3.13.x clusters. Co-authored-by: Cursor <cursoragent@cursor.com>
a63658d to
3e025ae
Compare
MirahImage
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
GinkgoHelper()for proper error reporting in test helper functionsEventuallyWithOffsetto returnerrorinstead ofboolfor cleaner error handlingExpectWithOffsetoffset values in nested callbacksdefer GinkgoRecover()withGinkgoHelper()for consistencyTest Plan
Made with Cursor