fix(sleep): drop stale embeddings with non-modal dimension#84
Open
rajkripal wants to merge 1 commit into
Open
Conversation
…mbedding_matrix Dream nodes embedded with the old all-MiniLM-L6-v2 model (384-dim) crash np.array() when mixed with gte-large embeddings (1024-dim). Filter to the modal dimension so sleep never crashes from leftover old-model embeddings. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
all-MiniLM-L6-v2model (384-dim) crashnp.array()when mixed with currentgte-largeembeddings (1024-dim)_load_embedding_matrixto keep only the modal dimension, dropping stale embeddings with a warning logTest plan
pytest tests/ -k sleep)ValueError: setting an array element with a sequenceNote:
test_think_ingest_respects_diversity_thresholdfails on main and is unrelated to this change.🤖 Generated with Claude Code