fix(cli): trigger in-process fallback when daemon returns empty string#85
Open
rajkripal wants to merge 1 commit into
Open
fix(cli): trigger in-process fallback when daemon returns empty string#85rajkripal wants to merge 1 commit into
rajkripal wants to merge 1 commit into
Conversation
The daemon returns `{"ok": True, "result": ""}` when it can't generate
context. The old check `if context is None` doesn't catch empty strings,
so the in-process fallback never ran and the user got "No context
generated" despite a working fallback path.
Fix: `if not context` catches both None and empty string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The daemon returns `{"ok": True, "result": ""}` when it can't generate
context. The old check `if context is None` doesn't catch empty strings,
so the in-process fallback never ran and the user got "No context
generated" despite a working fallback path.
Fix: `if not context` catches both None and empty string.