fix(sleep): use resolved model name in _embed_orphans#90
Open
rajkripal wants to merge 1 commit into
Open
Conversation
Hardcoded all-MiniLM-L6-v2 (384-dim) caused dimension mismatches after the project migrated to thenlper/gte-large (1024-dim). Now calls _resolve_default_model() from embedding_service so orphan embeddings always use the configured model. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_embed_orphansincore/sleep.pyhardcodedall-MiniLM-L6-v2(384-dim) as the embedding modelthenlper/gte-large(1024-dim), causing dimension mismatches when the sleep protocol ran on orphan nodes_resolve_default_model()fromembedding_service.pyand using the resolved model name both for loading the model and storing in theembeddingstableTest plan
python3 -m pytest tests/test_sleep.py -x -q— 38 passed🤖 Generated with Claude Code