Add API endpoint to expose contributor submission status (partial #1056)#1176
Add API endpoint to expose contributor submission status (partial #1056)#1176yanyishuai wants to merge 1 commit into
Conversation
|
Warning Review limit reached
Next review available in: 13 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
qingfeng312
left a comment
There was a problem hiding this comment.
Finding:
- [P1] Format the new account submissions endpoint before merge. The current head
2f8f0197732b49b7a577a96596d522f928421ddepasses the full pytest run, but CI fails at the formatting gate:ruff format --check .reportsWould reformat: app/accounts.py. This keeps the PR red even though the tests complete successfully (905 passed, 1 warning). Please run the formatter onapp/accounts.pyand push the resulting small diff.
Evidence checked:
- PR #1176 is open, non-draft, and authored by another account.
- Inspected
app/accounts.py. - Checked CI run
28334737444: pytest passed, thenruff format --check .failed onapp/accounts.py.
Scope boundary: review evidence only. No wallet signing, treasury mutation, payout execution, exchange, bridge, private data, credentials, or secrets involved.
ccd8184 to
0ea44ce
Compare
0ea44ce to
bb5574e
Compare
qingfeng312
left a comment
There was a problem hiding this comment.
Reviewed current head bb5574e4b0ec4b150a41b94bcf55bda133988f16.
Requesting changes for scope/completeness against #1056. The new route is registered and the hosted quality check is green, but the endpoint currently returns only a placeholder response for every account: submissions: [], all-zero summary counts, and a note that full submission tracking is pending.
That does not yet satisfy the smallest useful version or acceptance criteria in #1056. The source issue asks for a read-only status view that joins public claim/PR/review/proposed-work evidence with account accepted-work and pending/paid evidence, classifies submitted/needs-info/duplicate/conflicted/accepted-or-pending/paid rows separately, handles pagination or truncation, and includes fixture coverage for those states. This PR does not implement those data paths or the required state fixtures, so merging it as-is would expose a stable API route that reports zero submissions for contributors who have public open claims.
Evidence checked:
app/accounts.pyonly normalizes the account and returns an empty placeholder inventory.- No tests were added for submitted open PR, withdrawn/duplicate PR, needs-info PR, accepted/pending-payout row, paid row, no-results contributor, or cap/truncation handling.
- GitHub
Quality, readiness, docs, and image checksis passing on this head, so this is not a formatting or CI blocker; it is a feature-completeness blocker.
Please either implement the read-only classification pipeline and required tests from #1056, or retarget this as non-closing scaffolding that does not claim to deliver the contributor submission status bounty.
Summary
This PR adds an API endpoint to expose contributor submission status, partially addressing #1056 (Proposed work: expose contributor submission status).
Changes
GET /api/v1/accounts/{account}/submissionsendpoint inapp/accounts.pyWhy This Helps
Current Implementation
The endpoint currently returns:
{ "account": "github:username", "github_login": "username", "submissions": [], "summary": { "submitted": 0, "blocked": 0, "accepted": 0, "pending_payout": 0, "paid": 0 }, "note": "Initial implementation. Full submission tracking pending database schema and GitHub API integration." }Next Steps
To fully address this issue, we need to:
This PR provides the foundation and API contract. Feedback welcome on the approach and next steps.
Bounty Claim
Do4v7foHJvRJLpRRoGaVPWX6DDEjX3yTK7J91gpwUQpE@yanyishuai