Repository navigation
chore(deps): update GitPython to 3.2.0 - #220
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
joneill-r7
left a comment
There was a problem hiding this comment.
in order to release this you need a version bump in the _init_.py and a changelog entry. this has an example #218
|
Addressed review feedback: bumped |
|
|
||
| ## Changelog | ||
|
|
||
| * 2.47.35 - Updated dependencies to resolve Snyk vulnerabilities (`GitPython` 3.1.60) |
There was a problem hiding this comment.
Let's not mention vulnerabilities etc as its public library 😃
| * 2.47.35 - Updated dependencies to resolve Snyk vulnerabilities (`GitPython` 3.1.60) | |
| * 2.47.35 - Updated dependencies (`GitPython` 3.1.60) |
| PyYAML==6.0.1 | ||
| dacite==1.6.0 | ||
| GitPython==3.1.59 | ||
| GitPython==3.1.60 |
There was a problem hiding this comment.
How about bumping it to at least 3.1.62?
|
|
||
| ## Changelog | ||
|
|
||
| * 2.47.35 - Updated dependencies to resolve Snyk vulnerabilities (`GitPython` 3.1.60) |
There was a problem hiding this comment.
Since it's a public repo I would suggest to use just a Updated dependencies or similarly like in https://github.com/rapid7/icon-integrations-validators/pull/220/changes#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5L66
8fda3fc to
922504d
Compare
igorski-r7
left a comment
There was a problem hiding this comment.
LGTM, but probably worth testing with building it locally and running over an example plugin 😃
|
@lcwiklinski-r7 both points addressed in the latest commit: bumped |
lcwiklinski-r7
left a comment
There was a problem hiding this comment.
lgtm, make sure to align description and test it
0035835
922504d to
0035835
Compare
What
Updates the
GitPythondependency to the latest release and aligns the pin across both manifests.GitPythonrequirements.txt), 3.1.50 (setup.py)Why
GitPythonwas declared in two places with different exact pins —requirements.txt(3.1.59) andsetup.pyinstall_requires(3.1.50). Both were bumped to3.2.0(the current latest) so the runtime and install-time dependency sets stay consistent.GitPythonis used only inversion_bump_validator.py(Repo(),remote().refs, tree traversal,blob.data_stream). The 3.2.0 changelog's only breaking changes are dropping Python 3.7 support and deprecating theodbt=GitDBbackend — neither applies here (CI runs Python 3.11 and the code never passesodbt).Verification
GitPythonpin changed, in bothrequirements.txtandsetup.py; version bumped to2.47.35with a changelog entry.Fixes: SOAR-22160 | SOAR-22161 | SOAR-22162