[REVIEW] Define and implement new datetime_ops APIs#3201

Merged

harrism merged 46 commits intorapidsai:branch-0.11from

trxcllnt:libcudf++/datetime_ops

Nov 22, 2019

Contributor

trxcllnt commented Oct 23, 2019 •

edited

Loading

~~Do not merge until libcudacxx/pull/5 and libcxx/pull/17 are resolved.~~

This PR implements datetime_ops.cu for the new libcudf++ column using the new C++20 calendar functions in libcudacxx 🎉.

I made a few changes to column_view and column_device_view begin/end iterators which I found necessary, but feel free to suggest alternatives if you disagree.

Related issue: #2935

trxcllnt added 11 commits

October 21, 2019 17:16


          not working WIP

66502c3


          Merge branch 'branch-0.11' of github.com:rapidsai/cudf into libcudf++…

443f10e

…/datetime_ops


          add non working datetime_ops test

2b9b613


          fix CUDF_EXPECTS num_children checks

46c18c6


          Merge branch 'branch-0.11' into libcudf++/datetime_ops

64156ac


          more progress on datetime_ops


          fix const typings on mutable_column_view, add begin(), end() iterator…

3afc031

…s to column_device_view


          use chrono::system_clock

b6fa773


          make new datetime_ops tests pass

d78db7f


          Merge branch 'branch-0.11' into libcudf++/datetime_ops

734afe3


          move chrono edits into libcudacxx

1a12ec4

trxcllnt added the 0 - Blocked label

trxcllnt requested review from a team as code owners

October 23, 2019 20:29

trxcllnt commented

View reviewed changes

cpp/tests/datetime/datetime_ops_test.cu Outdated Show resolved Hide resolved

trxcllnt commented

View reviewed changes

cpp/src/datetime/datetime_ops.cu Outdated Show resolved Hide resolved

trxcllnt commented

View reviewed changes

cpp/src/datetime/datetime_ops.cu Outdated Show resolved Hide resolved

trxcllnt commented

View reviewed changes

cpp/tests/datetime/datetime_ops_test.cu Show resolved Hide resolved

trxcllnt commented

View reviewed changes

cpp/src/datetime/datetime_ops.cu Outdated Show resolved Hide resolved

trxcllnt commented

View reviewed changes

cpp/src/datetime/datetime_ops.cu Outdated Show resolved Hide resolved

trxcllnt commented

View reviewed changes

cpp/include/cudf/utilities/traits.hpp Show resolved Hide resolved

trxcllnt commented

View reviewed changes

cpp/include/cudf/utilities/chrono.hpp Show resolved Hide resolved

trevorsm7 mentioned this pull request

[FEA] Port contents of functions.h to new cudf::column and associated types #2931

Closed

12 tasks

trxcllnt added libcudf++ 2 - In Progress labels

jrhemstad requested changes

View reviewed changes

Contributor

jrhemstad left a comment

I'm over the moon at how clean this implementation is thanks to libcu++. 😍

cpp/src/datetime/datetime_ops.cu Outdated Show resolved Hide resolved

cpp/tests/datetime/datetime_ops_test.cu Outdated Show resolved Hide resolved

cpp/src/datetime/datetime_ops.cu Outdated Show resolved Hide resolved

cpp/src/datetime/datetime_ops.cu Outdated Show resolved Hide resolved

cpp/src/datetime/datetime_ops.cu Outdated Show resolved Hide resolved

cpp/src/datetime/datetime_ops.cu Outdated Show resolved Hide resolved

cpp/src/datetime/datetime_ops.cu Outdated Show resolved Hide resolved

cpp/tests/utilities/timestamp_utilities.cuh Outdated Show resolved Hide resolved

cpp/tests/datetime/datetime_ops_test.cu Outdated Show resolved Hide resolved

cpp/tests/datetime/datetime_ops_test.cu Outdated Show resolved Hide resolved

trxcllnt added 4 commits

October 28, 2019 12:22


          clean up datetime_ops.cu and datetime_ops_test.cu

484cb07


          Merge branch 'branch-0.11' into libcudf++/datetime_ops

1650d7c


          update to new libcu++ cuda::std namespace

95afd7c


          update libcudacxx ref

efa556a

trxcllnt mentioned this pull request

[REVIEW] Port NVStrings datetime conversion ops to cudf strings column #3232

Merged

trxcllnt added 4 commits

November 15, 2019 01:25


          rename datetime_component enum

60538c0


          add throwing, empty, and nullable datetime_ops tests

b89013d


          Merge branch 'branch-0.11' of github.com:rapidsai/cudf into libcudf++…

90fe38b

…/datetime_ops


          include traits.hpp

3a3028b

Contributor Author

trxcllnt commented Nov 15, 2019

rerun tests

harrism approved these changes

View reviewed changes

This was referenced Nov 16, 2019

C++20 to c++14 backports rapidsai/thirdparty-freestanding#1

Merged

C++20 to c++14 backports rapidsai/thirdparty-libcxx#2

Merged


          update libcudacxx submodule ref

86a7973

harrism requested a review from jrhemstad

November 17, 2019 21:30

trxcllnt removed the 2 - In Progress label

trxcllnt added 2 commits

November 20, 2019 10:54


          Merge branch 'branch-0.11' into libcudf++/datetime_ops

e2537d5


          Merge branch 'branch-0.11' of github.com:rapidsai/cudf into libcudf++…

8ada22f

…/datetime_ops

jrhemstad requested changes

View reviewed changes

cpp/include/cudf/column/column_device_view.cuh Outdated Show resolved Hide resolved

cpp/include/cudf/datetime.hpp Outdated Show resolved Hide resolved

cpp/include/cudf/datetime.hpp Outdated Show resolved Hide resolved

cpp/include/cudf/utilities/traits.hpp Show resolved Hide resolved

trxcllnt added 3 commits

November 20, 2019 15:44


          move legacy datetime functions to legacy header

5b0654b


          remove unused iterator fns

c3f6a2f


          add non-legacy header

582c025

harrism requested changes

View reviewed changes

Member

harrism left a comment

One thing missed.

cpp/include/cudf/datetime.hpp Outdated Show resolved Hide resolved

jrhemstad approved these changes

View reviewed changes

jrhemstad and others added 3 commits

November 21, 2019 11:02


          Merge branch 'branch-0.11' into libcudf++/datetime_ops

2d2e1f0


          uppercase datetime_component enum values

697e575


          Merge branch 'libcudf++/datetime_ops' of github.com:trxcllnt/cudf int…

1ea5784

…o libcudf++/datetime_ops

jrhemstad requested a review from harrism

November 21, 2019 18:45

Contributor Author

trxcllnt commented Nov 21, 2019

After this is merged we'll need folks to run this to update the libcu++ submodule correctly:

git submodule sync --recursive && git submodule update --init --recursive

harrism approved these changes

View reviewed changes


          Merge branch 'branch-0.11' into libcudf++/datetime_ops

5efead5

harrism merged commit b4a607a into rapidsai:branch-0.11

harrism mentioned this pull request

[FEA] Port date time.hpp to cudf::column types #2935

Closed

jlowe mentioned this pull request

[BUG] cudf++ timestamp downcast is incorrect for timestamps before the epoch #3664

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - Ready for Review