[REVIEW] Add utility to print column#3255
Merged
jrhemstad merged 20 commits intorapidsai:branch-0.11from Nov 19, 2019
Merged
Conversation
jrhemstad
requested changes
Oct 30, 2019
harrism
requested changes
Nov 1, 2019
sameerz
added
0 - Backlog
Member
|
rerun tests |
jrhemstad
requested changes
Nov 7, 2019
Codecov Report
@@ Coverage Diff @@
## branch-0.11 #3255 +/- ##
===========================================
Coverage 87.3% 87.3%
===========================================
Files 49 49
Lines 9215 9215
===========================================
Hits 8045 8045
Misses 1170 1170Continue to review full report at Codecov.
|
harrism
approved these changes
Nov 7, 2019
Member
|
Daily 5pm PST anaconda outage! rerun tests |
harrism
added
3 - Ready for Review
jrhemstad
requested changes
Nov 7, 2019
Contributor
jrhemstad
left a comment
jrhemstad
left a comment
There was a problem hiding this comment.
This is looking really good! Love the implementation.
Contributor
Author
|
Support for timestamps now dependent on #3232 |
jrhemstad
requested changes
Nov 15, 2019
Contributor
jrhemstad
left a comment
jrhemstad
left a comment
There was a problem hiding this comment.
I'm swooning over how nice the implementation is 😍
jrhemstad
approved these changes
Nov 15, 2019
jrhemstad
added
5 - Merge After Dependencies
and removed
3 - Ready for Review
Contributor
|
Should not be merged before #3232 |
Member
|
@ChuckHastings #3232 is merged, can you resolve conflicts here so we can merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds utility to convert a column to a string so it can be printed.
Addresses #3253
Depends on #3232