Skip to content

Make parquet memory tests opt-in - #547

Open
alexbarghi-nv wants to merge 2 commits into
rapidsai:release/26.10from
alexbarghi-nv:backport-pr-535-release-26.10
Open

alexbarghi-nv wants to merge 2 commits into
rapidsai:release/26.10from
alexbarghi-nv:backport-pr-535-release-26.10

Conversation

@alexbarghi-nv

Copy link
Copy Markdown
Member

Summary

  • backport Make parquet memory tests opt-in #535 to release/26.10
  • skip Parquet peak host-memory scaling tests by default because RSS varies nondeterministically across CI environments
  • keep both tests available for local investigation with PYLIBWHOLEGRAPH_RUN_PARQUET_MEMORY_TESTS=1
  • leave functional Parquet I/O coverage unchanged

Testing

  • git diff --check
  • PYTHONPYCACHEPREFIX=/tmp/cugraph-gnn-pr535-release-pycache python3 -m py_compile python/pylibwholegraph/pylibwholegraph/tests/pylibwholegraph/test_tensor_file_formats_io.py

(cherry picked from commit 259fdf8)
@alexbarghi-nv
alexbarghi-nv requested a review from a team as a code owner September 28, 2026 16:59
@copy-pr-bot

copy-pr-bot Bot commented Sep 28, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@alexbarghi-nv alexbarghi-nv added bug Something isn't working non-breaking Introduces a non-breaking change labels Sep 28, 2026
@greptile-apps

greptile-apps Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Greptile code reviews should be reviewed for accuracy and completeness. Please remember to give Greptile feedback (👍/👎) and consider leaving comments explaining why Greptile's feedback was helpful or not. This will help improve future code reviews.

RetriggerConfidence Score: 5/5

[Low risk] Makes parquet memory tests skip by default.

The PR appears safe to merge.

Summary

This backport makes both Parquet peak-memory tests opt-in while leaving functional Parquet I/O tests enabled. The change since the previous review is formatting only.

Reviews (2) · Last reviewed commit: "Apply ruff formatting"

@alexbarghi-nv

Copy link
Copy Markdown
Member Author

/ok to test 011a797

@alexbarghi-nv

Copy link
Copy Markdown
Member Author

/ok to test 0e3402c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant