Skip to content

Update nvForest to follow RAFT/RMM adopting cuda::stream_ref - #226

Open
chyunsu3 wants to merge 2 commits into
rapidsai:release/26.10from
chyunsu3:update_rmm_usage
Open

Update nvForest to follow RAFT/RMM adopting cuda::stream_ref#226
chyunsu3 wants to merge 2 commits into
rapidsai:release/26.10from
chyunsu3:update_rmm_usage

Conversation

@chyunsu3

@chyunsu3 chyunsu3 commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Update nvForest according to rapidsai/rmm#2372 and NVIDIA/raft#3129. Both changes landed in the 26.10 branch, so this PR also targets 26.10.

  • rmm::cuda_stream_view is now deprecated; we need to include <rmm/cuda_stream_view.hpp> explicitly now.
  • get_next_usable_stream() now returns cuda::stream_ref instead of rmm::cuda_stream_view

@chyunsu3
chyunsu3 requested a review from a team as a code owner September 14, 2026 00:40
@chyunsu3 chyunsu3 added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Sep 14, 2026
@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ddaaef25-e4b3-4455-a10c-5dee2011d499

📥 Commits

Reviewing files that changed from the base of the PR and between 1bba6d6 and 170b664.

📒 Files selected for processing (2)
  • cpp/include/nvforest/detail/owning_buffer/gpu.hpp
  • cpp/include/nvforest/handle.hpp

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Bug Fixes
    • Improved GPU stream handling for better compatibility with current stream interfaces.
    • Added the required support for GPU owning-buffer stream operations.

Walkthrough

The PR adds the RMM CUDA stream view header and changes GPU handle stream extraction from .value() to .get().

Changes

GPU stream handling

Layer / File(s) Summary
GPU stream interface updates
cpp/include/nvforest/detail/owning_buffer/gpu.hpp, cpp/include/nvforest/handle.hpp
The owning-buffer implementation includes rmm/cuda_stream_view.hpp. The GPU handle constructs cuda_stream from get_next_usable_stream().get().

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: csadorf

Merge Risk: ⚪ Minimal · up to 170b6

The CUDA stream API update and required header inclusion are consistent with the stated changes.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: updating nvForest to follow RAFT and RMM adoption of cuda::stream_ref.
Description check ✅ Passed The description directly explains the RMM and RAFT compatibility updates, including the explicit header include and the cuda::stream_ref API change.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@chyunsu3
chyunsu3 changed the base branch from main to release/26.10 September 14, 2026 00:48
@chyunsu3 chyunsu3 changed the title Update nvForest according to rapidsai/rmm#2372 Update nvForest to follow RAFT/RMM adopting cuda::stream_ref Sep 14, 2026
@chyunsu3 chyunsu3 self-assigned this Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CUDA/C++ improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant