Update nvForest to follow RAFT/RMM adopting cuda::stream_ref - #226
Open
chyunsu3 wants to merge 2 commits into
Open
Update nvForest to follow RAFT/RMM adopting cuda::stream_ref#226chyunsu3 wants to merge 2 commits into
cuda::stream_ref#226chyunsu3 wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe PR adds the RMM CUDA stream view header and changes GPU handle stream extraction from ChangesGPU stream handling
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The CUDA stream API update and required header inclusion are consistent with the stated changes. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
chyunsu3
force-pushed
the
update_rmm_usage
branch
from
September 14, 2026 00:48
170b664 to
a6f8a03
Compare
cuda::stream_ref
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update nvForest according to rapidsai/rmm#2372 and NVIDIA/raft#3129. Both changes landed in the 26.10 branch, so this PR also targets 26.10.
rmm::cuda_stream_viewis now deprecated; we need to include<rmm/cuda_stream_view.hpp>explicitly now.get_next_usable_stream()now returnscuda::stream_refinstead ofrmm::cuda_stream_view