# Description This takes care of several items related to data flow cleanup: - Makes "Follow measure" within the "Bar labels" dropdown a selectable (and default) option, rather than just placeholder text - closes rapidsai#486 - Hides data flow bars on DAG nodes when empty (rather than displaying empty bars) - closes rapidsai#533 - Improves DAG layout to ensure it's reactive to whether or not data flow is active - closes rapidsai#488 - Adds tabs to `DAGNodeInfoPanel` and moves data flow activity to second tab, so it is not conditionally rendered on top of the node statistics - closes rapidsai#532 - Improves data flow activity grid wrapping (removes wrapping, adds x-min-width and scrolls below that) - closes rapidsai#489* *Arguably this does not close out rapidsai#532 completely, since part of the ticket was to explore other layout options, but I think we can break that into a second ticket, as for now this fixes the poor text wrapping. ## Related Issues Closes rapidsai#486, rapidsai#533, rapidsai#488, rapidsai#532, rapidsai#489 ## Testing Issue rapidsai#486: 1. Ensure "Follow measure" is now the default option 2. Ensure the "Follow measure" option works as expected - change the "Flow measure" field and ensure "Bar labels" reacts accordingly Issue rapidsai#533 1. Ensure flow bars are no longer visible when there is no data to display and phantom bars are no longer rendered 2. Ensure bars are rendered and display data when there is activity for that node Issue rapidsai#488 1. Verify DAG nodes and edges respond appropriately when data flow is enabled and disabled 2. Make sure edges no longer get weird positioning, as posted through screenshot in issue Issue rapidsai#532 1. Verify `DAGNodeInfoPanel` now has two tabs and that you can switch between them 2. Ensure tabs _do not_ appear when data flow is disabled 3. Verify data flow state activity is now moved to second tab 4. Verify display text appears when there is no activity for the selected node Issue rapidsai#489 1. Reduce the size of the left panel, make sure table becomes horizontally scrollable 2. Verify data flow activity table no longer wraps, and no longer distorts column headers ## Screenshots Issue rapidsai#486 https://github.com/user-attachments/assets/944daf72-a677-4868-a5ac-2473d6f795ee Issue rapidsai#533: <img width="677" height="765" alt="Screenshot_20260805_105821" src="https://github.com/user-attachments/assets/4d9e3b79-a61b-4290-8c42-d988392c3a38" /> Issue rapidsai#488: Data flow enabled: <img width="831" height="1013" alt="Screenshot_20260805_110022" src="https://github.com/user-attachments/assets/c965ea3d-3648-49bc-a7dd-fb5f953b9935" /> Data flow disabled: <img width="835" height="1032" alt="Screenshot_20260805_110101" src="https://github.com/user-attachments/assets/8fbbd493-8d57-4334-ba7c-92fd62948427" /> Issue rapidsai#532: <img width="837" height="903" alt="image" src="https://github.com/user-attachments/assets/3041cdb7-0014-4053-942c-5181032d4d29" /> Issue rapidsai#489: https://github.com/user-attachments/assets/d189a726-fc73-4562-9441-2c8e3caeb521 Authors: - Chris Matzenbach (https://github.com/cmatzenbach) Approvers: - Joe O'Hallaron (https://github.com/johallar) URL: rapidsai#534

bug(ui): data-flow bars distort DAG layout #488

Description

Activity

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions