refactor(analyzer): convert FsmCollection to associated-type form - #256
Merged
Conversation
johanpel
added
non-breaking
johanpel
marked this pull request as ready for review
June 25, 2026 09:58
mbrobbel
approved these changes
Jun 25, 2026
Replace the FsmCollection<F, T> type parameters with a single associated `type Fsm`, so a collection exposes exactly one FSM type (an application with several kinds unifies them under one enum). Drop the unused contains_fsm_type method. Also drop the now-redundant T parameter from InMemoryFsms (it was only used in bounds; Fsm::TransitionType already carries the Transition bound), so its impls need just `F: Fsm`. Update the InMemoryFsms and SimulatorModel impls. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
johanpel
force-pushed
the
pr-fsm-collection
branch
from
June 25, 2026 12:41
e7e0af5 to
3d4b1fb
Compare
Contributor
Author
|
/merge |
rapids-bot Bot
pushed a commit
that referenced
this pull request
Jul 13, 2026
# Description
Adds `POST /api/engines/{engine_id}/entities`: a paginated query listing a
query's FSM entities ranked by longest resource-usage span (tiebroken by UUID),
to back the UI's long-entities view. Additive — no timeline changes.
Request: optional scope (resource / group), query-relative window, filters
(`entity_type_name`, `min_usage_s`), sort, page, and a per-query `OperatorFilter`.
Contract lives in `quent-ui`; a generic `entities::list_entities` ranks any
`FsmCollection` FSM, with operator filtering applied by the analyzer (kept out of
the generic filter).
Functional test over the fixed scenario captures events in memory via
`CallbackExporter` and reconstructs them with a new
`quent-simulator-instrumentation::test_utils` helper.
Depends on #256 and #257 (merged).
🤖 Generated with [Claude Code](https://claude.com/claude-code)
## Related Issues
Part of #214, isolated from #240
Authors:
- Johan Peltenburg (https://github.com/johanpel)
Approvers:
- Dhruv Vats (https://github.com/dhruv9vats)
URL: #258
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace
FsmCollection<F, T>with a single associatedtype Fsm, and drop theuncalled
contains_fsm_type. Lets a collection expose exactly one FSM type andunblocks bounding generic code on it. No behavior change.
🤖 Generated with Claude Code
Related Issues
Part of #214, split off from #240