Skip to content

chore(deps): move typescript to catalog, upgrade to 6 - #435

Merged
rapids-bot[bot] merged 1 commit into
rapidsai:mainfrom
johallar:typescript-bump
Jul 23, 2026
Merged

chore(deps): move typescript to catalog, upgrade to 6#435
rapids-bot[bot] merged 1 commit into
rapidsai:mainfrom
johallar:typescript-bump

Conversation

@johallar

@johallar johallar commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Description

Also moves other common deps to catalog for easier bumps

This should automatically close #338

@johallar
johallar marked this pull request as ready for review July 21, 2026 22:47
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: QUIET

Plan: Enterprise

Run ID: 1d4ac5aa-ecf0-4909-b090-643fba650c8a

📥 Commits

Reviewing files that changed from the base of the PR and between f7b37f1 and 45f363a.

⛔ Files ignored due to path filters (1)
  • ui/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml, !ui/pnpm-lock.yaml
📒 Files selected for processing (7)
  • ui/package.json
  • ui/packages/@quent/client/package.json
  • ui/packages/@quent/components/package.json
  • ui/packages/@quent/hooks/package.json
  • ui/packages/@quent/utils/package.json
  • ui/pnpm-workspace.yaml
  • ui/tsconfig.json
💤 Files with no reviewable changes (1)
  • ui/tsconfig.json

📝 Walkthrough

Walkthrough

Changes

UI configuration updates

Layer / File(s) Summary
Centralize UI dependency versions
ui/pnpm-workspace.yaml, ui/package.json, ui/packages/@quent/*/package.json
Shared catalog entries for clsx, tailwind-merge, tsdown, and typescript are added and referenced by the UI package manifests; typescript-eslint is also updated.
Remove TypeScript base URL
ui/tsconfig.json
Removes compilerOptions.baseUrl while retaining the existing path aliases.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: johanpel, cmatzenbach

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is missing the Related Issues, Testing, and Screenshots sections required by the template. Add the missing template sections, especially Related Issues and Testing, and include Screenshots if applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: moving TypeScript and other deps to the catalog while upgrading TypeScript to 6.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@johallar

Copy link
Copy Markdown
Contributor Author

/merge

@mbrobbel

Copy link
Copy Markdown
Member

Waiting on code owner review from cmatzenbach.

@johallar

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit 2e90569 into rapidsai:main Jul 23, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants