chore(ui): upgrade echarts to 6.x - #447
Conversation
… for cleaner look
Planning note accidentally committed with the echarts 6 upgrade; not part of the shipped change.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: QUIET Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe timeline UI now uses query-relative millisecond coordinates instead of epoch-based timestamps. Start-time props and conversions were removed across charts, tooltips, rulers, operator spans, and playhead synchronization. ECharts is upgraded to 6.1. ChangesRelative timeline UI
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Note
Quiet mode is enabled, so only the most important comments were posted inline. Other review comments are grouped below.
🟡 Other comments (1)
ui/packages/@quent/components/src/lib/timeline.utils.ts-41-46 (1)
41-46: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winCorrect the minimum-bin unit in the comments.
MIN_BIN_DURATION_NSis10, but the comments describe a 1 ns backend limit and 1 ns/bin zoom calculation. State 10 ns consistently so future changes do not derive the wrong minimum zoom constraint.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ui/packages/`@quent/components/src/lib/timeline.utils.ts around lines 41 - 46, Update the comments for MIN_BIN_DURATION_NS and the minimum visible zoom window to consistently state the backend minimum as 10 ns, including the zoom calculation’s per-bin duration, without changing the constant or behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Other comments:
In `@ui/packages/`@quent/components/src/lib/timeline.utils.ts:
- Around line 41-46: Update the comments for MIN_BIN_DURATION_NS and the minimum
visible zoom window to consistently state the backend minimum as 10 ns,
including the zoom calculation’s per-bin duration, without changing the constant
or behavior.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: QUIET
Plan: Enterprise
Run ID: 1aab9686-0d44-4037-941e-72fbab4fe33f
⛔ Files ignored due to path filters (1)
ui/pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml,!ui/pnpm-lock.yaml
📒 Files selected for processing (20)
ui/packages/@quent/components/package.jsonui/packages/@quent/components/src/dag/DagPlayhead.tsxui/packages/@quent/components/src/lib/timeline.utils.test.tsui/packages/@quent/components/src/lib/timeline.utils.tsui/packages/@quent/components/src/operator-timeline/OperatorGanttChart.tsxui/packages/@quent/components/src/operator-timeline/utils.test.tsui/packages/@quent/components/src/operator-timeline/utils.tsui/packages/@quent/components/src/resource-tree/UsageColumn.tsxui/packages/@quent/components/src/timeline/ResourceTimeline.tsxui/packages/@quent/components/src/timeline/Timeline.tsxui/packages/@quent/components/src/timeline/TimelineController.tsxui/packages/@quent/components/src/timeline/TimelineRuler.tsxui/packages/@quent/components/src/timeline/TimelineTooltip.test.tsxui/packages/@quent/components/src/timeline/TimelineTooltip.tsxui/packages/@quent/components/src/timeline/TimelineTooltipPortal.tsxui/packages/@quent/components/src/timeline/useVisibleMaxValue.tsui/pnpm-workspace.yamlui/src/components/DataFlowOverlay.test.tsxui/src/components/QueryPlan.tsxui/src/components/QueryResourceTree.tsx
💤 Files with no reviewable changes (2)
- ui/packages/@quent/components/src/timeline/TimelineTooltipPortal.tsx
- ui/packages/@quent/components/src/resource-tree/UsageColumn.tsx
Keep relative timeline axes from this branch while taking main's useMinZoomSpanPct / useTimelineWheelNavigation hooks.
|
/merge |
Description
startTimeparam since everything uses the relative seconds value now, big win IMORelated Issues
Testing
Note: bug: operator timeline allows unlimited zoom #445 Exists still, so the operator timeline won't stop you at the max zoom level and will break things, but will tackle that bug separately in refactor: hookify min zoom, use in all charts #446
Screenshots