Skip to content

chore(ui): upgrade echarts to 6.x - #447

Merged
rapids-bot[bot] merged 8 commits into
rapidsai:mainfrom
johallar:upgrade-echarts
Jul 28, 2026
Merged

chore(ui): upgrade echarts to 6.x#447
rapids-bot[bot] merged 8 commits into
rapidsai:mainfrom
johallar:upgrade-echarts

Conversation

@johallar

@johallar johallar commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Description

  • Upgrades echarts to 6.x
    • In order to do this we had to ditch the decimal millisecond timestamps which did not render correctly in 6. This now uses value type axes and use the "relative to start" seconds for the axes values (not timestamps).
    • This also allows us to have more precise bins, i've made them 10ns (previously 250)
    • Removes the startTime param since everything uses the relative seconds value now, big win IMO
  • Removes ignored vulnerability

Related Issues

Testing

Screenshots

@johallar
johallar marked this pull request as ready for review July 27, 2026 16:48
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: QUIET

Plan: Enterprise

Run ID: a6ff4106-ddd1-4a03-b0d9-456bf7e70117

📥 Commits

Reviewing files that changed from the base of the PR and between 1e8fb6a and 4cd9cc4.

📒 Files selected for processing (1)
  • ui/packages/@quent/components/src/lib/useMinZoomSpanPct.test.ts

📝 Walkthrough

Walkthrough

The timeline UI now uses query-relative millisecond coordinates instead of epoch-based timestamps. Start-time props and conversions were removed across charts, tooltips, rulers, operator spans, and playhead synchronization. ECharts is upgraded to 6.1.

Changes

Relative timeline UI

Layer / File(s) Summary
Relative timeline and operator data contracts
ui/packages/@quent/components/src/lib/timeline.utils.ts, ui/packages/@quent/components/src/operator-timeline/*, ui/packages/@quent/components/src/lib/timeline.utils.test.ts
Timeline marks, bins, and operator spans now use query-relative milliseconds without start-time parameters.
Relative chart rendering and tooltip flow
ui/packages/@quent/components/src/timeline/*, ui/packages/@quent/components/src/operator-timeline/OperatorGanttChart.tsx
Charts, rulers, controllers, overlays, tooltips, and visible-value calculations use duration-based value axes.
Playhead and application integration
ui/packages/@quent/components/src/dag/DagPlayhead.tsx, ui/packages/@quent/components/src/resource-tree/UsageColumn.tsx, ui/src/components/*
Playhead synchronization and component call sites no longer pass explicit query start timestamps.
ECharts workspace configuration
ui/packages/@quent/components/package.json, ui/pnpm-workspace.yaml
ECharts is updated to version 6.1, and an audit advisory ignore entry is removed.

Estimated code review effort: 4 (Complex) | ~45 minutes

Possibly related PRs

Suggested labels: ui, improvement

Suggested reviewers: mbrobbel, cmatzenbach, johanpel

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 45.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately reflects the main change: upgrading ECharts to 6.x.
Description check ✅ Passed The description covers the change, rationale, and testing, but Related Issues and Screenshots are left empty.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Quiet mode is enabled, so only the most important comments were posted inline. Other review comments are grouped below.

🟡 Other comments (1)
ui/packages/@quent/components/src/lib/timeline.utils.ts-41-46 (1)

41-46: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Correct the minimum-bin unit in the comments.

MIN_BIN_DURATION_NS is 10, but the comments describe a 1 ns backend limit and 1 ns/bin zoom calculation. State 10 ns consistently so future changes do not derive the wrong minimum zoom constraint.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@ui/packages/`@quent/components/src/lib/timeline.utils.ts around lines 41 -
46, Update the comments for MIN_BIN_DURATION_NS and the minimum visible zoom
window to consistently state the backend minimum as 10 ns, including the zoom
calculation’s per-bin duration, without changing the constant or behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Other comments:
In `@ui/packages/`@quent/components/src/lib/timeline.utils.ts:
- Around line 41-46: Update the comments for MIN_BIN_DURATION_NS and the minimum
visible zoom window to consistently state the backend minimum as 10 ns,
including the zoom calculation’s per-bin duration, without changing the constant
or behavior.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: QUIET

Plan: Enterprise

Run ID: 1aab9686-0d44-4037-941e-72fbab4fe33f

📥 Commits

Reviewing files that changed from the base of the PR and between b5ae4c7 and 714dc3e.

⛔ Files ignored due to path filters (1)
  • ui/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml, !ui/pnpm-lock.yaml
📒 Files selected for processing (20)
  • ui/packages/@quent/components/package.json
  • ui/packages/@quent/components/src/dag/DagPlayhead.tsx
  • ui/packages/@quent/components/src/lib/timeline.utils.test.ts
  • ui/packages/@quent/components/src/lib/timeline.utils.ts
  • ui/packages/@quent/components/src/operator-timeline/OperatorGanttChart.tsx
  • ui/packages/@quent/components/src/operator-timeline/utils.test.ts
  • ui/packages/@quent/components/src/operator-timeline/utils.ts
  • ui/packages/@quent/components/src/resource-tree/UsageColumn.tsx
  • ui/packages/@quent/components/src/timeline/ResourceTimeline.tsx
  • ui/packages/@quent/components/src/timeline/Timeline.tsx
  • ui/packages/@quent/components/src/timeline/TimelineController.tsx
  • ui/packages/@quent/components/src/timeline/TimelineRuler.tsx
  • ui/packages/@quent/components/src/timeline/TimelineTooltip.test.tsx
  • ui/packages/@quent/components/src/timeline/TimelineTooltip.tsx
  • ui/packages/@quent/components/src/timeline/TimelineTooltipPortal.tsx
  • ui/packages/@quent/components/src/timeline/useVisibleMaxValue.ts
  • ui/pnpm-workspace.yaml
  • ui/src/components/DataFlowOverlay.test.tsx
  • ui/src/components/QueryPlan.tsx
  • ui/src/components/QueryResourceTree.tsx
💤 Files with no reviewable changes (2)
  • ui/packages/@quent/components/src/timeline/TimelineTooltipPortal.tsx
  • ui/packages/@quent/components/src/resource-tree/UsageColumn.tsx

johallar added 2 commits July 28, 2026 11:18
Keep relative timeline axes from this branch while taking main's
useMinZoomSpanPct / useTimelineWheelNavigation hooks.
@johallar

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit 2ff193a into rapidsai:main Jul 28, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants