Skip to content

fix(schema, vibe): share Svelte runtime in Pages build - #546

Merged
rapids-bot[bot] merged 1 commit into
rapidsai:mainfrom
johanpel:schema-explorer-pages-fix
Aug 7, 2026
Merged

fix(schema, vibe): share Svelte runtime in Pages build#546
rapids-bot[bot] merged 1 commit into
rapidsai:mainfrom
johanpel:schema-explorer-pages-fix

Conversation

@johanpel

@johanpel johanpel commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Description

Externalize Svelte from the schema-viewer bundle so the viewer and custom node components share one runtime in production. This fixes the null nodes crash on GitHub Pages.

Also suppress the unnecessary /favicon.ico request.

Related Issues

Follow-up to #451.

Testing

  • Full experimental schema CI
  • Pages-equivalent headless browser test: HTTP 200, graph rendered, no console or page errors
  • License and whitespace checks

Written by Codex.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: QUIET

Plan: Enterprise

Run ID: 59da2c94-a687-4a6c-9cf5-eaea8245d736

📥 Commits

Reviewing files that changed from the base of the PR and between 8acccff and f07adc0.

📒 Files selected for processing (2)
  • experimental/vibe/ui/schema-explorer/index.html
  • experimental/vibe/ui/schema-viewer/vite.config.ts

📝 Walkthrough

Walkthrough

The schema explorer now declares an empty favicon. The schema viewer build externalizes svelte and svelte/* modules through Rolldown configuration.

Changes

Schema explorer metadata

Layer / File(s) Summary
Favicon declaration
experimental/vibe/ui/schema-explorer/index.html
Adds an empty data:, favicon link to the HTML head.

Schema viewer build configuration

Layer / File(s) Summary
Svelte module externalization
experimental/vibe/ui/schema-viewer/vite.config.ts
Configures Rolldown to exclude svelte and svelte/* modules from bundling.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • rapidsai/quent#389: Adds a related favicon declaration in another UI HTML file.
  • rapidsai/quent#451: Introduced the modified schema explorer HTML and schema viewer Vite configuration files.

Suggested reviewers: cmatzenbach, dhruv9vats, johallar

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: sharing the Svelte runtime in the Pages build.
Description check ✅ Passed The description covers the change, related issue, testing, and impact; the optional screenshots section is not required.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@johanpel

johanpel commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit 5817484 into rapidsai:main Aug 7, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants