fix(schema, vibe): share Svelte runtime in Pages build - #546
Merged
Conversation
johanpel
requested review from
9prady9,
cmatzenbach,
dhruv9vats,
felipeblazing,
johallar,
joosthooz and
mbrobbel
as code owners
August 7, 2026 11:11
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: QUIET Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe schema explorer now declares an empty favicon. The schema viewer build externalizes ChangesSchema explorer metadata
Schema viewer build configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
9prady9
approved these changes
Aug 7, 2026
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Externalize Svelte from the schema-viewer bundle so the viewer and custom node components share one runtime in production. This fixes the null
nodescrash on GitHub Pages.Also suppress the unnecessary
/favicon.icorequest.Related Issues
Follow-up to #451.
Testing
Written by Codex.