Update nuke.c to auto-detect flash size #653
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lurch
reviewed
Jun 17, 2025
Fixes raspberrypi#642 Thanks to @Gadgetoid for the work "Making A Thing" - Support [PiMoRoNi by buying stuff](https://shop.pimoroni.com/)!
If flash_do_cmd returns a bad size for the flash or fails, use a default flash size of 16MB
peterharperuk
force-pushed
the
flash-nuke-autodetect-size
branch
from
ce6dc26 to
9fb77ff
Compare
|
Please do not submit against |
peterharperuk
requested changes
Dec 12, 2025
Contributor
peterharperuk
left a comment
peterharperuk
left a comment
There was a problem hiding this comment.
-1 as this needs a fix to the sdk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #642
Original work by @Gadgetoid 🥇