Skip to content

fix deprecated client.request and vim.validate calls #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ray-x merged 1 commit into from
May 4, 2026
+9 −11
Merged

fix deprecated client.request and vim.validate calls #617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lua/go/gopls.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ local function apply_changes(cmd, args)
return
end
log('applying changes', cmd, args)
gopls.request('workspace/executeCommand', {
gopls:request('workspace/executeCommand', {
command = cmd,
arguments = args,
}, function(_err, changes)
Expand Down
18 changes: 8 additions & 10 deletions lua/go/lsp.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,12 +252,10 @@ M.codeaction = function(args)
local filters = args.filters or {}
local hdlr = args.hdlr
local range = args.range or false
vim.validate({
gopls_cmd = { gopls_cmd, 'string' },
only = { only, 'string', true },
filters = { filters, 'table', true },
hdlr = { hdlr, 'function', true },
})
vim.validate('gopls_cmd', gopls_cmd, 'string')
vim.validate('only', only, 'string', true)
vim.validate('filters', filters, 'table', true)
vim.validate('hdlr', hdlr, 'function', true)

hdlr = hdlr or function() end

Expand Down Expand Up @@ -299,7 +297,7 @@ M.codeaction = function(args)
fn(command, enriched_ctx)
hdlr()
else
gopls.request('workspace/executeCommand', {
gopls:request('workspace/executeCommand', {
command = command.command,
arguments = command.arguments,
workDoneToken = command.workDoneToken,
Expand Down Expand Up @@ -353,7 +351,7 @@ M.codeaction = function(args)

local action = actions[1]
-- resolve
gopls.request('codeAction/resolve', action, function(_err, resolved_action, ctx, config)
gopls:request('codeAction/resolve', action, function(_err, resolved_action, ctx, config)
trace('codeAction/resolve', resolved_action, ctx, config)
if _err then
log('error', _err)
Expand All @@ -373,7 +371,7 @@ M.codeaction = function(args)
end, bufnr)
end
trace('gopls.codeAction', gopls_cmd, only, bufnr, params)
gopls.request('textDocument/codeAction', params, ca_hdlr, bufnr)
gopls:request('textDocument/codeAction', params, ca_hdlr, bufnr)
end

M.gopls_on_attach = on_attach
Expand Down Expand Up @@ -561,7 +559,7 @@ function M.document_symbols(opts)
local symbols
local c = M.client()
if c ~= nil then
return c.request_sync('textDocument/documentSymbol', params, opts.timeout or 1000, vim.api.nvim_get_current_buf())
return c:request_sync('textDocument/documentSymbol', params, opts.timeout or 1000, vim.api.nvim_get_current_buf())
end
end

Expand Down
Loading