Expose clip prop on Annotate#721
Open
morningsend wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose an optional
clipprop onAnnotateand pass it through toGenericChartComponent.Why
Annotatecurrently renders throughGenericChartComponentwith its defaultclip: truebehavior. That means annotation SVG is clipped to the chart plot area viachart-area-clip-{chartId}. For marker-style annotations such as entry/exit badges, labels, or callouts, consumers sometimes need the marker to render just outside the plot boundary while still following pan/zoom.This keeps the existing behavior by default (
clip: true) and lets users opt out with:Validation
Ran with Node 18/npm 9 because the repo toolchain does not bootstrap under Node 26: