Skip to content

Conversation

@alanleedev
Copy link
Collaborator

@alanleedev alanleedev commented Nov 20, 2024

Summary:

Changelog:

[GENERAL][REMOVED] - Removed SafeAreaView usage in template app

Test Plan:

Manually editing generated template app.

iOS with SafeAreaView:

ios_with_safeareaview.mp4

iOS without SafeAreaView:

ios_without_safeareaview.mp4

They look the same with or without the SafeAreaView.


Note: It was not handled in the PR but leaving a note as future reference. Safe area seems to be handled in ScrollView with contentInsetAdjustmentBehavior="automatic" prop (code here). Removing this on iOS looks like this:

ios_without_contentInsetAdjustmentBehavior_automatic.mp4

@liamjones
Copy link

liamjones commented Nov 20, 2024

They look the same with or without the SafeAreaView.

Does this hold true for the device in landscape orientation too?

@alanleedev
Copy link
Collaborator Author

alanleedev commented Nov 20, 2024

Does this hold true for the device in landscape orientation too?

That is good question. Landscape does become a bit of an issue.

Without SafeAreaView on iOS
without

With SafeAreaView on iOS
with

@alanleedev
Copy link
Collaborator Author

Closing for now due to landscape issue.

@alanleedev alanleedev closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants