Use umbrellas instead of direct includes in react/runtime module (#58550)

Summary:
Pull Request resolved: #58550

Changelog: [Internal]

Part of the C++ stable API migration to umbrella includes. Fixes tier reachability violations in the `react/runtime` module.

The headers in this module are "for frameworks" tier (they include `<react/cxxstableapi/FrameworksGuard.h>`), but they reached public-tier modules through fine-grained includes: `<ReactCommon/CallInvoker.h>`, `<ReactCommon/SchedulerPriority.h>`, `<ReactCommon/RuntimeExecutor.h>` and `<cxxreact/JSBigString.h>`. Each of these is protected by `<react/cxxstableapi/UmbrellaGuard.h>`. Exported headers are preprocessed in the consumer's translation unit, so a consumer building with `RN_STRICT_API` would hit the guard through these transitive includes. `RN_ALLOW_FRAMEWORKS` does not suppress the guard.

This change switches the five affected headers (`BridgelessNativeMethodCallInvoker.h`, `BufferedRuntimeExecutor.h`, `CallInvokerImpl.h`, `ReactInstance.h`, `TimerManager.h`) to the `<React/CallInvoker.h>`, `<React/RuntimeExecutor.h>` and `<React/JSBigString.h>` umbrellas. Each umbrella scopes `RN_UMBRELLA_CONTEXT` around its includes, so the guard accepts them. `<ReactCommon/SchedulerPriority.h>` has no include of its own anymore because `<React/CallInvoker.h>` re-exports it. The umbrellas are supersets of the headers they replace, so every previously visible declaration stays available and there is no functional change.

Out of scope: `ReactInstance.cpp` and the module's C++ tests keep the fine-grained includes. They are compiled only within React Native's own build and are never preprocessed by consumers, which matches the umbrellas' documented guidance. Other modules are migrated in separate changes.

Reviewed By: cortinico, javache

Differential Revision: D120316197

fbshipit-source-id: 580b5da536607cf56fe1af607058d6851cda79ce

Author: j-piasecki

packages/react-native/ReactCommon/react/runtime/BridgelessNativeMethodCallInvoker.h

@@ -9,7 +9,7 @@
 
 #include <react/cxxstableapi/FrameworksGuard.h>
 
-#include <ReactCommon/CallInvoker.h>
+#include <React/CallInvoker.h>
 #include <cxxreact/MessageQueueThread.h>
 #include <memory>
 

packages/react-native/ReactCommon/react/runtime/BufferedRuntimeExecutor.h

@@ -9,8 +9,8 @@
 
 #include <react/cxxstableapi/FrameworksGuard.h>
 
-#include <ReactCommon/RuntimeExecutor.h>
-#include <ReactCommon/SchedulerPriority.h>
+#include <React/CallInvoker.h>
+#include <React/RuntimeExecutor.h>
 #include <jsi/jsi.h>
 #include <atomic>
 #include <memory>

packages/react-native/ReactCommon/react/runtime/CallInvokerImpl.h

@@ -9,8 +9,7 @@
 
 #include <react/cxxstableapi/FrameworksGuard.h>
 
-#include <ReactCommon/CallInvoker.h>
-#include <ReactCommon/SchedulerPriority.h>
+#include <React/CallInvoker.h>
 #include <react/renderer/runtimescheduler/RuntimeScheduler.h>
 #include <react/runtime/BufferedRuntimeExecutor.h>
 

packages/react-native/ReactCommon/react/runtime/React-RuntimeCore.podspec

@@ -36,7 +36,7 @@ Pod::Spec.new do |s|
   resolve_use_frameworks(s, header_mappings_dir: "../..", module_name: "React_RuntimeCore")
 
   s.dependency "React-jsiexecutor"
-  s.dependency "React-cxxreact"
+  add_dependency(s, "React-cxxreact")
   add_dependency(s, "React-runtimeexecutor", :additional_framework_paths => ["platform/ios"])
   s.dependency "React-jsi"
   s.dependency "React-jserrorhandler"

packages/react-native/ReactCommon/react/runtime/ReactInstance.h

@@ -9,9 +9,9 @@
 
 #include <react/cxxstableapi/FrameworksGuard.h>
 
-#include <ReactCommon/CallInvoker.h>
-#include <ReactCommon/RuntimeExecutor.h>
-#include <cxxreact/JSBigString.h>
+#include <React/CallInvoker.h>
+#include <React/JSBigString.h>
+#include <React/RuntimeExecutor.h>
 #include <cxxreact/MessageQueueThread.h>
 #include <jserrorhandler/JsErrorHandler.h>
 #include <jsi/jsi.h>

packages/react-native/ReactCommon/react/runtime/TimerManager.h

@@ -9,7 +9,7 @@
 
 #include <react/cxxstableapi/FrameworksGuard.h>
 
-#include <ReactCommon/RuntimeExecutor.h>
+#include <React/RuntimeExecutor.h>
 #include <unordered_map>
 #include <vector>
 

packages/react-native/ReactCommon/react/runtime/platform/ios/React-RuntimeApple.podspec

@@ -41,7 +41,7 @@ Pod::Spec.new do |s|
   resolve_use_frameworks(s, header_mappings_dir: "./", module_name: "React_RuntimeApple")
 
   s.dependency "React-jsiexecutor"
-  s.dependency "React-cxxreact"
+  add_dependency(s, "React-cxxreact")
   s.dependency "React-callinvoker"
   add_dependency(s, "React-runtimeexecutor", :additional_framework_paths => ["platform/ios"])
   s.dependency "React-runtimescheduler"