Merged
Conversation
Re-applies 4 custom Readwise features on top of upstream v13.16.0: 1. setTintColor command - controls WebView selection/tint color via RGBA doubles. Fixed Fabric signature to match codegen protocol (4 doubles instead of UIColor), preventing SIGABRT on New Architecture. 2. scrollsToTop prop - controls scroll-to-top on status bar tap. 3. dragInteractionEnabled prop - controls drag interactions on the webview. 4. forceLightScrollIndicators is NOT re-added — upstream v13.14.0+ has indicatorStyle prop which supersedes it with more flexibility. Co-Authored-By: Claude Opus 4.6 <[email protected]>
WKWebView pages loaded with about:blank origin (via loadHTMLString:baseURL:) cannot access file:// URLs. This custom scheme handler serves files from the app bundle (fonts, etc.) via rw-asset:///filename URLs, bypassing the file:// security restriction. Co-Authored-By: Claude Opus 4.6 <[email protected]>
jhlabs
approved these changes
Feb 9, 2026
| // Register custom URL scheme handler to serve app bundle assets (fonts, etc.) | ||
| // from WKWebView pages loaded with about:blank origin, which can't access file:// URLs. | ||
| RNCAssetSchemeHandler *assetHandler = [[RNCAssetSchemeHandler alloc] init]; | ||
| [wkWebViewConfig setURLSchemeHandler:assetHandler forURLScheme:@"rw-asset"]; |
There was a problem hiding this comment.
This is iOS 11+ only and I think we have a target of iOS 9? We should probably check if we need to safely escape if we are on an earlier version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-add Readwise custom features on v13.16.0
Syncs the Readwise fork to upstream v13.16.0 and re-applies our 3 custom iOS features with full Fabric (new architecture) support.
Features
setTintColorcommand (iOS only)Imperative method to set the WebView's tint color via RGBA values. Used for highlight selection colors in the reader — transparent during resize, yellow for auto-highlight, blue
default.