Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HorizontalSelector has a bug with showing items when an adapter is updated from the LiveData observer. Sometimes it works fine, sometimes layout for items is not fully loaded and it shows only Command and State. HorizontalSelectorExampleActivity has LiveData implementation and the bug reproduces. FragmentHorizontalSelectorExample doesn't have LiveData implementation and the bug doesn't reproduce. I think the problem is inside of notifyDataSetChanged().
The real use-case scenario: Inject an adapter into Activity using Hilt. Observe changes with LiveData from the network or database and update an adapter when new data come.
See this video to understand what it looks like:
https://www.youtube.com/watch?v=S_ZIjq9NKVs
UXLibrary version: 1.5.0.493
Device: Navigator 500
This PR doesn't fix the bug! I don't have access to library code, so I reproduce the state where this bug appears and you can try it. Please, open the Issues page for this repository!