ENG-8904: Update footer

[carlosabadia]

No description provided.

[linear]

ENG-8904 Update footer design

[greptile-apps]

Greptile Summary

This PR consolidates the site footer into a single shared footer_index component, replacing three separate footer implementations (footer, footer_customer, and various bottom_section usages). The redesigned footer features a new layout with a logo, reorganized link sections (Product, Solutions, Resources), a newsletter signup, social media icons, and a dark mode toggle. A new shared divider component is introduced as a visual separator before the footer. Several page templates and pages are updated to use the unified footer.

• Footer consolidation: Deleted pcweb/pages/customers/views/footer.py and replaced all footer_customer, bottom_section, and old footer usages across 7 templates/pages with footer_index
• New shared divider: Created pcweb/pages/framework/views/divider.py with gradient edge effects, used consistently before the footer
• New footer icons: Added 6 new SVG icons (twitter_footer, linkedin_footer, forum_footer, moon_footer, sun_footer, computer_footer) for the redesigned footer
• Design updates: Changed --text-xs CSS variable from 0.75rem to 0.8125rem (global impact), updated dark mode toggle styling, standardized email placeholder to "Email"
• Issue: footer_link applies target="_blank" to all links including internal routes (/docs, /faq, etc.), which will open internal navigation in new tabs

Confidence Score: 3/5

• The footer consolidation is well-structured, but the target="_blank" on internal links needs to be fixed before merging.
• The PR is a clean refactor that successfully unifies multiple footer implementations. The code structure is sound and all old imports have been properly cleaned up. However, the target="_blank" on footer_link affects all footer links including internal routes, which will cause unexpected new-tab navigation for users clicking links like Documentation, FAQ, Framework, etc. The global --text-xs CSS variable change could also have unintended side effects across the site.
• pcweb/pages/framework/views/footer_index.py needs attention for the target="_blank" issue on internal links. assets/tailwind-theme.css has a global --text-xs size increase that may affect other components.

Important Files Changed

Filename	Overview
pcweb/pages/framework/views/footer_index.py	Major rewrite of the unified footer component. New layout with logo, reorganized link sections (Product, Solutions, Resources), newsletter, social icons, and dark mode toggle. Uses target="_blank" on all links including internal routes, which is a UX issue.
pcweb/pages/framework/views/divider.py	New shared divider component with gradient edge effects, used as a separator before the footer across multiple page templates.
pcweb/components/icons/icons.py	Added six new SVG icon definitions for the footer: twitter_footer, linkedin_footer, forum_footer, moon_footer, sun_footer, computer_footer.
assets/tailwind-theme.css	Increased --text-xs from 0.75rem to 0.8125rem and line-height from 1rem to 1.25rem. This is a global change that affects all elements using the text-xs size class.
pcweb/pages/customers/views/footer.py	Deleted the customer-specific footer. All customer pages now use the shared footer_index component.
pcweb/templates/storypage.py	Replaced footer_customer and bottom_section with shared divider + footer_index. Footer moved outside the inner content box for consistent layout.
pcweb/templates/highlightpage.py	Replaced footer_customer and bottom_section with shared divider + footer_index. Changed font class from font-instrument-sans to font-sans.
pcweb/templates/gallery_app_page.py	Replaced bottom_section with shared divider + footer_index. Footer moved outside the inner content box for consistent layout.
pcweb/templates/mainpage.py	Replaced get_started section with divider before footer. Removed unused get_started import.
pcweb/templates/marketing_page.py	Replaced bottom_section + old footer with shared footer_index component.
pcweb/templates/webpage.py	Replaced bottom_section + old footer with shared footer_index component.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    subgraph Before["Before: Multiple Footer Implementations"]
        F1["footer (pcweb/views/footer.py)"]
        F2["footer_customer (pcweb/pages/customers/views/footer.py)"]
        BS["bottom_section"]
        
        T1["webpage.py"] --> BS & F1
        T2["marketing_page.py"] --> BS & F1
        T3["mainpage.py"] --> GS["get_started"]
        T4["gallery_app_page.py"] --> BS
        T5["highlightpage.py"] --> BS & F2
        T6["storypage.py"] --> BS & F2
    end

    subgraph After["After: Unified Footer"]
        FI["footer_index (framework/views/footer_index.py)"]
        DV["divider (framework/views/divider.py)"]
        
        T1a["webpage.py"] --> FI
        T2a["marketing_page.py"] --> FI
        T3a["mainpage.py"] --> DV & FI
        T4a["gallery_app_page.py"] --> DV & FI
        T5a["highlightpage.py"] --> DV & FI
        T6a["storypage.py"] --> DV & FI
    end

    Before -.->|"PR #1762"| After

Loading

_{Last reviewed commit: 31ad29f}

[greptile-apps]

_{18 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}