Remove sleep from listeners, add Async task scoping to Server#run#7
Merged
henrikbjorn merged 1 commit intomasterfrom Mar 16, 2026
Merged
Remove sleep from listeners, add Async task scoping to Server#run#7henrikbjorn merged 1 commit intomasterfrom
henrikbjorn merged 1 commit intomasterfrom
Conversation
The sleep in run_session was unnecessary — the read_loop in Client/Server keeps the connection alive until FreeSWITCH closes it. Server#run now wraps in Async do |task| with task.children.each(&:wait) to properly drain in-flight connections on shutdown, matching the async-http pattern.
c960657
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sleepfromInbound#run_sessionandOutbound#run_session— the read_loop in Client/Server keeps the connection alive, events are dispatched from the read_loop fiber not the session taskServer#runinAsync do |task|withtask.children.each(&:wait)to drain in-flight connections on shutdown, matching the async-http patternThe sleep was added in 81014f3 to "keep session task alive for event hooks and child tasks" but event hooks are dispatched by
handle_responsewhich runs in the read_loop fiber, not the session task. The session task completing has no effect on event delivery.