Skip to content

Conversation

@ryantm
Copy link
Collaborator

@ryantm ryantm commented Jan 29, 2026

Why

  • turns out gcp won't accept a disk image unless it is called "disk.raw"
  • we should also just output the sqshfs for dev like we did before to keept he same interface

What changed

  • Change the disk name is disk-script to disk.raw
  • Split the disk script into dev and prod scripts

Test plan

  • both dev and prod scripts can be built locally

Why
===
* turns out gcp won't accept a disk image unless it is called
"disk.raw"
* we should also just output the sqshfs for dev like we did before to
keept he same interface

What changed
===
* Change the disk name is disk-script to disk.raw
* Split the disk script into dev and prod scripts

Test plan
===
* both dev and prod scripts can be built locally
@ryantm ryantm requested a review from a team as a code owner January 29, 2026 15:43
@ryantm ryantm requested review from cbrewster and eastlondoner and removed request for a team January 29, 2026 15:43
@ryantm ryantm enabled auto-merge January 29, 2026 15:50
@ryantm ryantm merged commit 570399a into main Jan 29, 2026
3 checks passed
@ryantm ryantm deleted the rtm0129diskscript branch January 29, 2026 15:57
Copy link

@eastlondoner eastlondoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants