Implement interceptors to support OTel tracing#110
Closed
Conversation
Member
Author
|
Current dependencies on/for this PR: This comment was autogenerated by Freephite. |
cbrewster
force-pushed
the
11-15-Implement_interceptors_to_support_OTel_tracing
branch
from
87c1210 to
edf77b9
Compare
Member
Author
|
Can hold off until #106 lands |
cbrewster
force-pushed
the
11-15-Implement_interceptors_to_support_OTel_tracing
branch
3 times, most recently
from
ba65d56 to
eabb561
Compare
cbrewster
force-pushed
the
11-15-Implement_interceptors_to_support_OTel_tracing
branch
from
eabb561 to
527fd16
Compare
cbrewster
commented
Nov 21, 2024
| procedureName: Optional[str] = None | ||
| streamId: str | ||
| controlFlags: int | ||
| tracing: Optional[PropagationContext] = None |
Member
Author
There was a problem hiding this comment.
Need to get around to populating these fields so we can get traces across client/server boundary
cbrewster
added a commit
that referenced
this pull request
Nov 21, 2024
Why === Supercedes #110, we want to punt desingin interceptors until later. We'd like to have tracing between client and server, this implements spans for the client side. What changed ============ - Add tracing spans for each procedure call - Add support for propagating the tracing context to the river server using the tracing field of the transport message - Ideally the trasnsport message wouldn't hardcode the tracing fields, but we'd need to fix that in the JS implementation Test plan ========= - Connect this up to our internal usage, we should see spans for river procedure calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We'd like to see river spans, this adds support for a basic interceptor framework, this let's us build layers for tracings, metrics, and logging.
What changed
ClientInterceptorabstract base class to define the interceptor interfaceOpenTelemetryClientInterceptorwhich provides spans for all procedure callsTest plan