Enable the clippy::pedantic lint group - #43
Open
emilk wants to merge 2 commits into
Open
Conversation
Instead of opting in to pedantic lints one by one, enable the whole group and opt out of the noisy ones, like in emilk/egui#8429. Lints that were already enabled one-by-one here stay enabled. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
emilk
marked this pull request as ready for review
August 18, 2026 08:59
emilk
added a commit
to rerun-io/revy
that referenced
this pull request
Aug 18, 2026
cargo-cranky is unmaintained, and Cargo has supported lint tables since 1.74, so the lints move into Cargo.toml and CI calls `cargo clippy` directly. The lint set is the one from rerun_template: all of `clippy::pedantic` on, with the unhelpful ones opted out one by one. See rerun-io/rerun_template#43. `disallowed-macros` now says `std::dbg`, since plain `dbg` does not name a reachable macro and clippy 1.95 warns about it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
emilk
added a commit
to rerun-io/quiver
that referenced
this pull request
Aug 18, 2026
Instead of opting in to pedantic lints one by one, enable the whole group and opt out of the noisy ones, mirroring rerun-io/rerun_template#43 The only new hit was `copy_iterator` on `ListValue`, which is intentional. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
rerun-sync Bot
pushed a commit
to rerun-io/rerun
that referenced
this pull request
Aug 19, 2026
### Related Same pattern as: * emilk/egui#8429 * emilk/eframe_template#236 * emilk/egui_plot#255 * rerun-io/egui_table#63 * rerun-io/egui_tiles#155 * rerun-io/rerun_template#43 ### What Instead of opting in to pedantic lints one by one, enable the whole group in both the `rerun` and the `dataplatform` workspace, and opt out of the noisy ones. This deletes 91 explicit lint lines per workspace and picks up new pedantic lints for free. Each opt-out carries its hit count, so the cost of turning one back on is visible. `restriction` and `nursery` stay opt-in per lint. One commit per lint fixed. --------- Source-Ref: 9b69ee8f23610b9b427da62f8ab9f6cf782a9a3d Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Enables the clippy::pedantic lint group at the workspace level (with low priority), and explicitly opts out of a small set of noisy pedantic lints while preserving existing explicit lint settings.
Changes:
- Enable
pedanticas a workspace Clippy lint group (warn,priority = -1). - Remove many individually-listed pedantic lints that are now covered by the group.
- Add an allowlist for selected pedantic lints to reduce noise (e.g., float comparisons, casts, naming-related lints).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
IsseW
pushed a commit
to rerun-io/quiver
that referenced
this pull request
Aug 20, 2026
* chore: bump MSRV to 1.95.0 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * chore: enable the `clippy::pedantic` lint group Instead of opting in to pedantic lints one by one, enable the whole group and opt out of the noisy ones, mirroring rerun-io/rerun_template#43 The only new hit was `copy_iterator` on `ListValue`, which is intentional. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * docs: add `# Panics` sections, enabling `missing_panics_doc` Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
emilk
commented
Aug 20, 2026
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of opting in to pedantic lints one by one, enable the whole group and opt out of the noisy ones, mirroring emilk/egui#8429.
Lints that were already enabled here one-by-one stay enabled, so this only adds coverage. Clippy is clean with this.
Matching PRs: rerun-io/egui_table#63, rerun-io/egui_tiles#155, emilk/egui_plot#255, emilk/eframe_template#236.