Update MSRV to 1.95 and fix CI - #14
Open
emilk wants to merge 4 commits into
Open
Conversation
bevy 0.19 enables both `x11` and `wayland` in its default feature set (via `default_platform`), so `wayland-sys` now needs `wayland-client.pc` at build time. cargo-deny-action v1 ships a cargo-deny too old to parse CVSS 4.0 scores, which now appear in the RustSec advisory database (e.g. RUSTSEC-2026-0038), making every run fail while loading the database. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
emilk
changed the title
emilk
marked this pull request as draft
August 18, 2026 13:16
The old dependencies tripped ten RustSec advisories. Most are fixed by a lockfile update, but the patched `time` needs a compiler that understands edition 2024, hence the MSRV bump. `cargo update` fixes `bytes`, `crossbeam-epoch`, `h2`, `lz4_flex`, `time` and `tracing-subscriber`. The three that remain need semver-major bumps we cannot do here, so deny.toml ignores them: * RUSTSEC-2026-0097: `rand` 0.8 is unsound; the fix is in `rand` 0.9. * RUSTSEC-2026-0192: `ttf-parser` is unmaintained, with no safe upgrade. * RUSTSEC-2026-0206: `rustybuzz` is unmaintained, reached via `cosmic-text`. `twox-hash` joins `skip-tree`, since the newer `lz4_flex` uses 2.x while rerun is still on 1.x. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
cargo-cranky is unmaintained, and Cargo has supported lint tables since 1.74, so the lints move into Cargo.toml and CI calls `cargo clippy` directly. The lint set is the one from rerun_template: all of `clippy::pedantic` on, with the unhelpful ones opted out one by one. See rerun-io/rerun_template#43. `disallowed-macros` now says `std::dbg`, since plain `dbg` does not name a reachable macro and clippy 1.95 warns about it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Mostly mechanical, from `cargo clippy --fix`: `use_self`, trait imports as `_`, `?` instead of `and_then` chains, `is_some_and` instead of `map_or`, and `#[expect]` instead of `#[allow]`. By hand: * `ancestors_from_world` uses `?` rather than nested `if let`, which also drops the `collapsible_match` exception. * `component_to_ron` and `component_to_hash` release the type-registry read guard before the work that does not need it. * The deliberate casts in `Mesh::to_rerun` get an `#[expect]` with a reason. * The Bevy examples get file-level `#[expect]`s, so they stay close to the upstream sources they were copied from. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long time no update