feat(editor): add Inspector.Node and Inspector.Text#3187
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Contributor
|
This review could not be run because your cubic account has exceeded the monthly review limit. If you need help restoring access, please contact contact@cubic.dev. |
commit: |
3 tasks
gabrielmfern
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Inspector.Node— render-props component for inspecting selected nodes (styles, attributes, theme defaults)Inspector.Text— render-props component for inspecting text selections (marks, alignment, link, parent block styles)Inspectorcompound component + context typesAPI
Context
Part of the inspector sidebar redesign (PRODUCT-1739). This is the core API PR — defines the render-props context objects that consumers and pre-built section components will use.
Depends on #3183 (hooks), #3185 (primitives), #3186 (pickers).
Test plan
pnpm lint:fixpassesSummary by cubic
Add
Inspector.NodeandInspector.Textrender-props components to inspect and edit the selected node or text. This is the core API for the inspector sidebar redesign (PRODUCT-1739) and enables theme-aware custom inspector UIs.Inspector.Node: read/write node styles and attributes, batch style updates, accessnodeType/nodePos, theme defaults, and document preset colors.Inspector.Text: read/toggle marks, set alignment, read/write link href/color, and update parent block styles with theme defaults and preset colors.Inspectorcompound (Inspector.Node,Inspector.Text) plus context/prop types.Written for commit 5bf13cb. Summary will update on new commits.