Bundle libfakemallinfo.so to work around mallinfo() SIGILL on >2 GiB heaps - COR-1118#82
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Contributor
Author
|
@claude review once |
mchelnokov
force-pushed
the
libfakemallinfo
branch
from
9466ab2 to
e103a8c
Compare
ArmorDarks
requested review from
a team,
SoftwareArchitector,
Copilot and
neodesys
There was a problem hiding this comment.
Pull request overview
This pull request bundles a small LD_PRELOAD shared library (libfakemallinfo.so) into the published Ubuntu 22.04-based GStreamer images to work around crashes in third-party callers still using glibc’s deprecated mallinfo() once heaps exceed ~2 GiB.
Changes:
- Add a new C source file implementing a
mallinfo()shim returning a zeroedstruct mallinfo. - Build
libfakemallinfo.soduring the existing/compilestep and copy it into/compiled-binariesso it propagates to all image variants via existingCOPY --from=0behavior. - Ensure the build stage has access to the shim source by copying it into the
dev-downloadedstage.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Dockerfile-dev-downloaded.in | Copies fake_mallinfo.c into the build stage so /compile can build the shim. |
| docker/build-gstreamer/fake_mallinfo.c | Introduces the mallinfo() interposer implementation. |
| docker/build-gstreamer/compile | Builds and installs libfakemallinfo.so into both the live filesystem and /compiled-binaries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…heaps CEF/Chromium's MemoryInfra calls glibc's deprecated mallinfo(), whose return struct uses `int` fields. Once heap addresses exceed 2 GiB the arithmetic inside glibc overflows and triggers a SIGILL, crashing the process at random. See chromiumembedded/cef#3963 ("linux: Random crash due to MemoryInfra"): chromiumembedded/cef#3963 Build a tiny LD_PRELOAD shim that overrides mallinfo() to return a zeroed struct, and stage it into /compiled-binaries/usr/lib so the existing `COPY --from=0 /compiled-binaries /` steps propagate it into all four published image variants. Consumers opt in by setting LD_PRELOAD=/usr/lib/libfakemallinfo.so for processes that load CEF.
mchelnokov
force-pushed
the
libfakemallinfo
branch
from
e103a8c to
ba7b3c2
Compare
ArmorDarks
force-pushed
the
libfakemallinfo
branch
4 times, most recently
from
6cc6736 to
de812cc
Compare
ArmorDarks
force-pushed
the
libfakemallinfo
branch
from
de812cc to
57db7ed
Compare
Member
|
Added some additional docs. good to go |
ArmorDarks
approved these changes
May 7, 2026
ArmorDarks
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundle libfakemallinfo.so LD_PRELOAD shim in published images
glibc's deprecated mallinfo() returns int fields that overflow once heap addresses exceed 2 GiB, causing SIGILL in callers that still use it. Ship a tiny shared library that returns a zeroed struct mallinfo, ready to be loaded via LD_PRELOAD=libfakemallinfo.so.
Build it from docker/build-gstreamer/fake_mallinfo.c at the top of the existing /compile script and install to both /usr/lib/ (live) and /compiled-binaries/usr/lib/. Routing through /compiled-binaries piggybacks on the existing COPY --from=0 steps, so the .so lands in all four published variants (latest-dev-with-source, latest-dev, latest-prod, latest-prod-dbg) with no changes to dev-dependencies or prod-base.