2026 Updates - Part 2 - #2
Merged
Merged
Conversation
zachcmielreverb
requested review from
Copilot and
reverb-ios-robot
and removed request for
a team
July 23, 2026 17:14
zachcmielreverb
requested review from
JohnBueno and
nathanhreverb
and removed request for
reverb-ios-robot
July 23, 2026 17:14
JohnBueno
approved these changes
Jul 23, 2026
There was a problem hiding this comment.
Pull request overview
Adds GraphQL request/response models for a listing detail endpoint, enabling the app’s networking layer to represent (encode/decode) listing detail queries similarly to the existing listings search flow.
Changes:
- Added
ListingsDetailRequest(GraphQL query + variables) for fetching listing detail by ID. - Added
ListingsDetailResponse(decodable model hierarchy) for parsing the listing detail GraphQL response. - Registered the new Swift files in the Xcode project so they build with the target.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Interview/Networking/ListingsDetailRequest.swift | Adds an encodable GraphQL request for listing detail by ID. |
| Interview/Networking/ListingsDetailResponse.swift | Adds decodable models for the listing detail GraphQL response payload. |
| Interview.xcodeproj/project.pbxproj | Includes the new request/response files in the project and build sources. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
ListingsDetailRequestandListingsDetailResponse