Move sequence-array publication off participant startup's critical path - #1370
Draft
JackWilb wants to merge 2 commits into
Draft
Move sequence-array publication off participant startup's critical path#1370JackWilb wants to merge 2 commits into
JackWilb wants to merge 2 commits into
Conversation
Contributor
|
A preview of 22d5bb1 is uploaded and can be seen here: ✨ https://revisit.dev/study/PR1370 ✨ Changes may take a few minutes to propagate. |
10 tasks
28 tasks
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The first participant after a config change previously generated and uploaded the full sequence array before participant initialization could continue. It also deleted the prior mutable artifact, which made artifact lifetime depend on the active config rather than participant sessions.
This change establishes a small transactional build record first. Concurrent clients derive the same array from its seed, while only the lease owner uploads the canonical artifact. Failed or abandoned publishers can be replaced without changing the seed.
Closes #1319.
Validation
yarn install --frozen-lockfileyarn unittest --run(2,036 tests passed, 1 skipped)yarn typecheckyarn lintyarn buildgit diff --check