Preview NASA-TLX and SMEQ slider values on hover - #1441
Conversation
|
🪓 PR closed, deleted preview. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f38b4f9113
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| generateSliderBreakValues: vi.fn(() => []), | ||
| })); | ||
| vi.mock('../sliderBreaks', async (importOriginal) => { | ||
| const actual = await importOriginal<typeof import('../sliderBreaks')>(); |
There was a problem hiding this comment.
This new typeof import('../sliderBreaks') type query is inside the mock callback, directly violating the repository requirement that imports—including type imports—be declared at the top of the file. Add a top-level type import and use its alias with importOriginal instead.
AGENTS.md reference: AGENTS.md:L53-L54
Useful? React with 👍 / 👎.
jaykim1213
changed the title
JackWilb
left a comment
JackWilb
left a comment
There was a problem hiding this comment.
Verified the exact current head manually: NASA-TLX sliders use step=5, pointer selection resolves to five-point increments, and keyboard movement advances by five. The existing head already implements the requested behavior; no code change was needed.
2 participants
Does this PR close any open issues?
Closes #1089
Give a longer description of what this PR addresses and why it's needed
Hover effect for the sliders
Provide pictures/videos of the behavior before and after these changes (optional)
Are there any additional TODOs before this PR is ready to go?
TODOs: