Skip to content

fix(codex): do not split CRLF SSE events at one line ending - #58

Open
rexdotsh wants to merge 1 commit into
mainfrom
fix/codex-sse-crlf-boundaries
Open

rexdotsh wants to merge 1 commit into
mainfrom
fix/codex-sse-crlf-boundaries

Conversation

@rexdotsh

Copy link
Copy Markdown
Owner

Summary

  • Treat \r\n as a single SSE line ending when looking for a blank event separator, including when the buffer contains mixed newline styles.
  • Add a regression with a CRLF-delimited response.done event: the event line and JSON data remain in the same frame and are both normalized to response.completed, with usage captured.

This is audit finding #11 only; it does not change Claude SSE or PR #49. bun test (141 passing), bun lint, bun typecheck. Leave unmerged for review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant