Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
message_startalready reports input/cache tokens; preserve those even when a turn ends beforemessage_delta. Codex can preserve any usage already observed in a parsed event before cancellation.Limit: this cannot recover tokens the upstream has not reported yet. In particular, Codex commonly sends usage only in its terminal event, so a cancellation before that event can still be unmeasured. No estimates are fabricated.
Addresses the recoverable part of audit finding #7 only, independently of #49 and the other audit PRs.
bun test(143 passing),bun lint,bun typecheck. No live provider requests. Leave unmerged for review.