Skip to content

[CRM-14077] Lift PHP cap to <8.4 and add 8.3 to CI - #2

Merged
MichaelEsteves merged 3 commits into
mainfrom
chore/CRM-14077-php83-cap-lift
Jul 3, 2026
Merged

[CRM-14077] Lift PHP cap to <8.4 and add 8.3 to CI#2
MichaelEsteves merged 3 commits into
mainfrom
chore/CRM-14077-php83-cap-lift

Conversation

@MichaelEsteves

@MichaelEsteves MichaelEsteves commented Jul 3, 2026

Copy link
Copy Markdown

Feature overview/Issue description

Part of the wings-api PHP 7.4 → 8.3 upgrade (CRM-14074, deps slice CRM-14077 group 5): this package's <8.3 PHP cap is one of the last composer-level blockers for running wings-api on 8.3.

Summary of changes

  • composer.json: PHP constraint >=7.4 <8.3>=7.4 <8.4
  • CI: PHP 8.3 added to the test matrix (where a matrix exists)

Per the epic's design (D6): constraint-lift + 8.3 CI only — code changes happen only if this package's own 8.3 CI fails.

Blockers

  • After merge, please tag a release — wings-api consumes all group-5 lifts in one lock-bump PR once every tag exists.

🤖 Generated with Claude Code

MichaelEsteves and others added 2 commits July 3, 2026 11:03
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Jul 3, 2026

Copy link
Copy Markdown

Greptile Summary

This PR lifts the PHP version constraint in composer.json from <8.3 to <8.4 and adds PHP 8.3 to the GitHub Actions CI test matrix. The constraint and CI matrix are internally consistent with each other.

  • composer.json: PHP constraint updated to >=7.4 <8.4, unblocking consumption by projects running PHP 8.3.
  • .github/workflows/pr_test.yml: PHP 8.3 added to the matrix.php array, providing direct CI coverage for the newly declared compatibility range.

Confidence Score: 5/5

Safe to merge — the constraint lift and CI addition are minimal, targeted, and consistent with each other.

Both changed files touch only version declarations: the composer constraint moves from <8.3 to <8.4, and the CI matrix adds 8.3 to match. No logic, no migrations, no API changes. The only noteworthy discrepancy is that the PR title and description say <8.5 while the actual code landed at <8.4; this is a stale description rather than a code defect.

No files require special attention.

Important Files Changed

Filename Overview
composer.json PHP constraint lifted from <8.3 to <8.4, enabling 8.3.x compatibility; note the PR title/description incorrectly states <8.5.
.github/workflows/pr_test.yml PHP 8.3 added to the CI test matrix; consistent with the <8.4 constraint in composer.json.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[composer.json constraint] -->|was: >=7.4 <8.3| B[PHP 7.4 – 8.2 supported]
    A -->|now: >=7.4 <8.4| C[PHP 7.4 – 8.3 supported]
    D[CI matrix] -->|added: 8.3| E[Tests: 7.4, 8.0, 8.1, 8.2, 8.3]
    E -->|each with| F[prefer-lowest]
    E -->|each with| G[prefer-stable]
    C --- E
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[composer.json constraint] -->|was: >=7.4 <8.3| B[PHP 7.4 – 8.2 supported]
    A -->|now: >=7.4 <8.4| C[PHP 7.4 – 8.3 supported]
    D[CI matrix] -->|added: 8.3| E[Tests: 7.4, 8.0, 8.1, 8.2, 8.3]
    E -->|each with| F[prefer-lowest]
    E -->|each with| G[prefer-stable]
    C --- E
Loading

Reviews (2): Last reviewed commit: "fix: CRM-14077 narrow the lift to <8.4 —..." | Re-trigger Greptile

Comment thread composer.json Outdated
…range

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@MichaelEsteves
MichaelEsteves merged commit 00676f7 into main Jul 3, 2026
11 checks passed
@MichaelEsteves MichaelEsteves changed the title [CRM-14077] Lift PHP cap to <8.5 and add 8.3 to CI [CRM-14077] Lift PHP cap to <8.4 and add 8.3 to CI Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants