Skip to content

Update csproj to latest format and target netstandard1.0 and PCL (portable-net45+win8+wp8)#170

Open
Mark-RSK wants to merge 30 commits into
rid00z:masterfrom
Mark-RSK:netstandard
Open

Update csproj to latest format and target netstandard1.0 and PCL (portable-net45+win8+wp8)#170
Mark-RSK wants to merge 30 commits into
rid00z:masterfrom
Mark-RSK:netstandard

Conversation

@Mark-RSK

Copy link
Copy Markdown

I have updated all nuget references and included the latest Xamarin.Forms that has a netstandard target. To allow the project to build correctly for netstandard and use the inbuilt nuget packing in VS2017 I have moved the IOC files into the main project.

I have tested bringing in the compiled nuget into both a netstandard and PCL XF core project and both function correctly.

Your thoughts on the implementation would be much appreciated as I have attempted this as a way of learning the new csproj structure

@Mark-RSK

Copy link
Copy Markdown
Author

#160

@Mark-RSK

Copy link
Copy Markdown
Author

For a working netstandard Xamarin Forms template the following link has a great explanation, and also a repo with the template included.

https://oren.codes/2017/04/23/using-xamarin-forms-with-net-standard-vs-2017-edition/

@Ebsan

Ebsan commented Jul 12, 2017

Copy link
Copy Markdown

I think the line count reduction of ~11,000 lines speaks to Oren's idea that .NET Standard reduces "gunk".

@JimSEOW

JimSEOW commented Aug 7, 2017

Copy link
Copy Markdown

@Mark-RSK I came here because I need FreshMVVM to work with Rx.NET with .NET standards 1.6 support.
The project is changed to 1.4 to make it compatible with Xamarin Forms UWP.

@JimSEOW

JimSEOW commented Aug 7, 2017

Copy link
Copy Markdown

[FreshMVVm + ReactiveUI ]+ ReactiveExtension

@Mark-RSK

Mark-RSK commented Aug 7, 2017

Copy link
Copy Markdown
Author

@JimSEOW I have updated the project to use the PackageTargetFallback attribute in the csproj so the stable release of Xamarin Forms is used. I have also removed the PCL output of the library as this caused issues in Visual Studio Mac

@JimSEOW

JimSEOW commented Aug 8, 2017

Copy link
Copy Markdown

@Mark-RSK

The FreshMVVM.Tests complains!
Error NU1202 Package Microsoft.TestPlatform.TestHost 15.0.0 is not compatible with netstandard1.4 (.NETStandard,Version=v1.4). Package Microsoft.TestPlatform.TestHost 15.0.0 supports:

  • net45 (.NETFramework,Version=v4.5)
  • netstandard1.5 (.NETStandard,Version=v1.5)

@JimSEOW

JimSEOW commented Aug 8, 2017

Copy link
Copy Markdown

@Mark-RSK Why I have to keep the FreshMVVM to .NET standard 1.0 and not 1.4 (causing errors in TinyIoC.cs)

However, now that It compiles, I can NOW start combining ReactiveUI and ReactiveExtension to target UWP .net standard 1.4 (so that when UWP is .NET standard 2.0 compliance, we would have learn many issues before then).

@JimSEOW JimSEOW mentioned this pull request Aug 8, 2017
@Mark-RSK

Copy link
Copy Markdown
Author

@JimSEOW It seems TinyIoC hasn't been updated in a while and the ifdefs were incorrect for net standard 1.4. I have updated the ifdef's to include 1.3 & 1.4 and it now all compiles.

I apologise for the earlier checkin that failed to build. I had changed the csproj type of the test project from netstandard to net461 on my master branch but hadn't made the change in this branch.

@jfversluis

Copy link
Copy Markdown

I am waiting for this! Nice work :)

@JimSEOW

JimSEOW commented Aug 11, 2017

Copy link
Copy Markdown

@Mark-RSK thanks.

@JimSEOW

JimSEOW commented Aug 11, 2017

Copy link
Copy Markdown

@Mark-RSK These are the failed tests
2017-08-11_19-01-32

@Mark-RSK

Copy link
Copy Markdown
Author

@JimSEOW I've fixed the failing tests. Not sure the tests would have passed on the original master branch. I am unable to build the original master to check

@Mark-RSK Mark-RSK closed this Aug 12, 2017
@Mark-RSK Mark-RSK reopened this Aug 12, 2017
@Mark-RSK

Copy link
Copy Markdown
Author

Building the original branch in VS2015 and running the tests, the same tests fail

@rid00z

rid00z commented Aug 12, 2017 via email

Copy link
Copy Markdown
Owner

@daveclarke

Copy link
Copy Markdown

Without wishing to be rude/pushy, is there any progress on merging this PR? Thanks :-)

@rid00z

rid00z commented Jun 2, 2019

Copy link
Copy Markdown
Owner

@daveclarke @Mark-RSK @jfversluis Apologies for the slow reply, we've upgrade to .NET Standard already but there's a few nice commits/ideas in here that I will take a look at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants