Open
Conversation
2 tasks
groverlynn
force-pushed
the
coalesced_modifier
branch
from
0de0b31 to
4453c13
Compare
groverlynn
force-pushed
the
coalesced_modifier
branch
from
4453c13 to
bc47555
Compare
LEOYoon-Tsaw
force-pushed
the
master
branch
6 times, most recently
from
4346417 to
111e615
Compare
igncp
pushed a commit
to igncp/mac-rume
that referenced
this pull request
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When detecting non-coalesced modifier key events, ignore any modifier's key up preceded with mouse and other key events after the said modifier's key down, in combination with rime/librime#647. This fixes #681 #721
In theory, this should also enable detecting keycode to distinguish left/right modifiers in older OSX. But as I don't have any old OSX environment, tests are not done. Links to #715