Repository navigation
Conversation
Both matrix include entries only added new keys, so the second overwrote the first and the job built cp314t alone. Make tag a real axis.
Contributor
|
luhenry
force-pushed
the
main
branch
3 times, most recently
from
October 1, 2026 15:22
39fb7ba to
a75cf68
Compare
…path multipart_test.py, request_test.py and response_test.py all build request bodies from these three repo-root files via a path relative to the repo root; CIBW_TEST_SOURCES only staged tests/, so every one of those tests hit a FileNotFoundError, surfaced as a DecodingError once that exception inside the async body-stream left httpbin nothing to respond with.
test_send_async_bytes_stream, test_send_sync_bytes_stream and test_multiple_requests still failed on both legs after the test files were staged: the httpbin log shows each of their POSTs answered with a 501. Those tests send a streamed body, so the request goes out with Transfer-Encoding: chunked, and httpbin's before_request hook aborts any chunked request with 501 "Chunked requests are not supported" unless SERVER_SOFTWARE starts with gunicorn/. `python -m httpbin.core` runs it on the Werkzeug dev server, so it always takes that branch. Upstream's tests job runs httpbin from the kennethreitz/httpbin container, which serves it with gunicorn, so do the same here: install gunicorn (pure Python) next to httpbin and start httpbin:app with it on 127.0.0.1:8080. The gthread worker keeps keep-alive connections and concurrent requests working. Also correct the CIBW_TEST_SOURCES comment, which blamed the DecodingError on the missing files rather than on the 501.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wreq0.12.1Compiles the wreq-python PyO3 extension, which statically links BoringSSL through btls-sys. Upstream publishes no riscv64 wheel.
Mirrors upstream's
ci.yml(manylinuxandtestsjobs).Differs from upstream
dnf install clang-devel git- btls-sys needs libclang for bindgen and git to patch BoringSSL.wreqcrate pinned to 6.0.0-rc.29 - Cargo.lock is gitignored; the release sdist locks rc.29.CARGO_BUILD_JOBS=2- limits rustc memory on the riscv64 runners.Matrix:
cp311-abi3(built on cp312, tested on cp312-cp314) andcp314t, matching upstream's wheel set.Testing
kennethreitz/httpbinimage also serves it with gunicorn; httpbin rejects chunked requests with a 501 on any other server, which breaks the streamed-body tests).License: Wheel statically links BoringSSL (ISC/OpenSSL-style), same as upstream's wheels.