Repository navigation
onnxsim: Add version 0.8.1 - #2846
Draft
riseproject-dev[bot] wants to merge 3 commits into
Draft
riseproject-dev[bot] wants to merge 3 commits into
riseproject-dev[bot] wants to merge 3 commits into
Conversation
Signed-off-by: riseproject-dev[bot] <330740410+riseproject-dev[bot]@users.noreply.github.com>
Contributor
|
Nightly version bump omitted the patches/onnxsim/<version> directory for 0.8.1, so the build's unconditional `git apply .../*.patch` step failed with "No such file or directory" before any build/test ran. Copied forward the same patch set from 0.7.3 (unchanged since then).
onnxsim 0.8.1 rewrote tests/test_profiling.py's _foldable_model() to build its model through a new _model() helper (onnx.parser.parse_model) that stamps ir_version=10 by default, instead of the bare helper.make_model(graph, opset_imports=[...]) call our patch pinned. That is exactly the fix the patch carried, so the carried-forward copy no longer applies (hunk at tests/test_profiling.py:29) and has nothing left to change; 0.7.3 keeps it. With no patches left for 0.8.1, guard the "Apply patches" step on hashFiles() like build-fastparquet.yml does, so a version without a patches/onnxsim/<version>/ directory skips the step instead of failing git apply on an unmatched glob.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically generated by the nightly
check_versions.pyrun.onnxsim v0.7.3 -> v0.8.1
Every
- version:entry added todocs/packages/onnxsim.yamlis built by this PR's ownbuild-onnxsim.ymlrun; merging publishes the wheels.