Skip to content

[Resource Leak] Redis connection pool never disconnected on shutdown#2887

Open
sanrishi wants to merge 1 commit into
ritesh-1918:gssocfrom
sanrishi:fix/redis-connection-lifecycle
Open

[Resource Leak] Redis connection pool never disconnected on shutdown#2887
sanrishi wants to merge 1 commit into
ritesh-1918:gssocfrom
sanrishi:fix/redis-connection-lifecycle

Conversation

@sanrishi

Copy link
Copy Markdown

Adds pool.disconnect() and app shutdown hook to gracefully close Redis connections. Fixes #2874

- Fix CacheService.close() to disconnect the connection pool (pool.disconnect())
- Add cleanup_cache_service() module-level function
- Register app shutdown handler in main.py to close Redis on exit
- Prevents lingering Redis connections on process restart

Fixes ritesh-1918#2874
@vercel

vercel Bot commented Jun 14, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the ritesh Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Jun 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1ae8f745-60c1-4ab5-ace6-03dc87f759b7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant