hwplib 업스트림 d9e073d6 동기화 및 1.1.10.8 버전 업데이트 - #14
Conversation
업스트림 d9e073d6 변경 사항 반영: - FillInfo PictureInfo의 contrast/brightness 읽기·쓰기 순서를 HWP 파일 형식에 맞게 교정 (contrast 먼저, brightness 다음) 같은 커밋에 포함된 About.java 버전 문자열 변경은 C#에서는 csproj 버전으로 관리되므로 해당 없음. 이슈 #303 관련 HWPReader 수정(feff19ee)은 이미 C#에 반영되어 있음을 확인함. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR successfully synchronizes with upstream hwplib commit d9e073d6 and correctly fixes the byte order issue for reading and writing Contrast and Brightness fields in PictureInfo. The changes ensure proper alignment with the HWP file format specification.
The modifications are well-coordinated:
- Reader and Writer are updated symmetrically to maintain consistency
- Version properly bumped to 1.1.10.8
- All tests (162 for net8.0 and net472) pass as reported
No blocking issues found. The PR is ready to merge.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
There was a problem hiding this comment.
Pull request overview
This pull request synchronizes the C# port with upstream hwplib commit d9e073d6, correcting the on-disk byte order for PictureInfo’s contrast/brightness fields in BorderFill picture fill handling, and bumps the library version to 1.1.10.8.
Changes:
- Fix
PictureInfoserialization order to write/read Contrast first, then Brightness to match the HWP format (and upstream). - Keep reader/writer behavior symmetric by applying the same ordering fix in both paths.
- Update NuGet/assembly version metadata from
1.1.10.7→1.1.10.8.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/hwplibsharp/Writer/DocInfo/BorderFill/ForFillInfo.cs | Writes PictureInfo fields in corrected order (Contrast → Brightness). |
| src/hwplibsharp/Reader/DocInfo/BorderFill/ForFillInfo.cs | Reads PictureInfo fields in corrected order (Contrast → Brightness). |
| src/hwplibsharp/hwplibsharp.csproj | Bumps project/package/assembly/file versions to 1.1.10.8. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closes #12
변경 사항
업스트림 hwplib의 새 커밋 d9e073d6 을 분석하여 반영했습니다.
1. FillInfo PictureInfo 바이트 순서 교정 (실질 변경)
BorderFill의 그림 채우기 정보에서contrast/brightness를 읽고 쓰는 순서가 HWP 파일 형식과 반대로 되어 있던 것을 업스트림과 동일하게 교정했습니다 (contrast 먼저, brightness 다음).Reader/DocInfo/BorderFill/ForFillInfo.cs—ReadPictureInfoWriter/DocInfo/BorderFill/ForFillInfo.cs—PictureInfo읽기/쓰기가 대칭으로 수정되어 라운드트립 동작에는 영향이 없고, 실제 한글 파일과의 필드 해석이 올바르게 됩니다.
2. 반영 불필요 항목 확인
ReadScripts()에 try/catch로 이미 반영되어 있음을 확인3. 서브모듈 및 버전
hwplib서브모듈 포인터를origin/main(d9e073d6)으로 업데이트테스트
🤖 Generated with Claude Code