fix(amp): show credits in overview for credits-only users#263
fix(amp): show credits in overview for credits-only users#263
Conversation
🤖 Augment PR SummarySummary: Adjusts the Amp provider so the Changes: Moves 🤖 Was this summary useful? React with 👍 or 👎 |
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
augment review |
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Amp provider’s manifest so the Credits metric is visible on the Overview card for credits-only accounts, adds a regression test for a newer credits-only displayText variant, and updates provider documentation to match the new visibility behavior.
Changes:
- Move Amp
Creditsline fromdetailtooverviewscope in the plugin manifest. - Add a test covering credits-only
displayTextthat includes an automatic top-up hint suffix. - Update Amp provider docs to describe when
Creditsappears on the overview card.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| plugins/amp/plugin.test.js | Adds a regression test for parsing credits-only text that includes the automatic top-up hint. |
| plugins/amp/plugin.json | Moves the Credits line to overview scope so Overview filtering includes it. |
| docs/providers/amp.md | Updates documentation to reflect that Credits is now an overview-visible line (including credits-only accounts). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
|
I was the one who implemented Amp. I thought I handled the credits thing correctly, but it seems I was wrong. Thank you 🥰 |
Summary
Creditsline tooverviewscope so credits-only accounts show data on the overview card.Screenshots
Before
After
Testing
bunx vitest run plugins/amp/plugin.test.jsbunx vitest run src/pages/overview.test.tsxbun run test:coverage(fails on currentmainbaseline too: branch coverage89.61%vs threshold90%)