feat: support booleans, integers in android#32
Open
sdenaci wants to merge 2 commits intorobinpowered:masterfrom
Open
feat: support booleans, integers in android#32sdenaci wants to merge 2 commits intorobinpowered:masterfrom
sdenaci wants to merge 2 commits intorobinpowered:masterfrom
Conversation
|
I also need support for boolean restriction types so would like to see this feature added. Is this project still active and maintained? |
|
Would like to have this merged too, so that boolean restriction type can be supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, for configurations in Android which are booleans or integers, the values are not bridged accurately to React-Native.
In the case of booleans, they always converted to null.
In the case of integers, they are converted to strings.
This pr determines whether type of the restriction value (integer, boolean, or string) and then writes the correct type to the WritableMap which is bridged to React-Native.
To test: