add osgi metadata

[zspitzer]

Hi There,

I've filed a PR for Commonmark which uses your nice library!

commonmark/commonmark-java#359

as I'm adding some Commmonmark extensions to Lucee
lucee/Lucee#2473

This PR adds the maven-bundle-plugin to the build to add the OSGI metadata required

[robinst]

The official guide seems to recommend a different approach:

https://felix.apache.org/documentation/subprojects/apache-felix-maven-bundle-plugin-bnd.html#_adding_osgi_metadata_to_existing_projects_without_changing_the_packaging_type

Where does your approach come from, and what is the difference?

[zspitzer]

I tried the standard approach and it was adding to many exports to the MANIFEST, feel free to try it out locally

[robinst]

I meant these bits:

                        <supportedProjectTypes>
                            <supportedProjectType>jar</supportedProjectType>
                            <supportedProjectType>bundle</supportedProjectType>
                        </supportedProjectTypes>
...
                    <executions>
                        <execution>
                            <id>manifest</id>
                            <goals>
                                <goal>manifest</goal>
                            </goals>
                            <configuration>
                                <supportIncrementalBuild>true</supportIncrementalBuild>
                            </configuration>
                        </execution>
                        <execution>
                            <id>bundle</id>
                            <goals>
                                <goal>bundle</goal>
                            </goals>
                        </execution>
                    </executions>

I've pushed commits to the branch to follow the linked instructions above, and it still produces the same end result. Note that before, it looks like it built the jar file twice:

[INFO] --- jar:3.4.1:jar (default-jar) @ autolink ---
[INFO] Building jar: /Users/robinst/private/autolink-java/target/autolink-0.11.1-SNAPSHOT.jar
[INFO]
[INFO] --- bundle:5.1.9:bundle (bundle) @ autolink ---
[INFO] Building bundle: /Users/robinst/private/autolink-java/target/autolink-0.11.1-SNAPSHOT.jar
[INFO] Writing manifest: /Users/robinst/private/autolink-java/target/classes/META-INF/MANIFEST.MF
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS

After:

[INFO] --- jar:3.4.1:jar (default-jar) @ autolink ---
[INFO] Building jar: /Users/robinst/private/autolink-java/target/autolink-0.11.1-SNAPSHOT.jar
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS

[robinst]

@zspitzer Let me know if that works for you, and happy to proceed with this.

[robinst]

@zspitzer Ping?

[robinst]

@zspitzer One more ping; otherwise I'll assume there's no problem doing it this way and will proceed.

[robinst]

Released in 0.12.0.