Repository navigation
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8e21696f0f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if pyproject.toml_path(project_path).exists(): | ||
| project = pyproject.load(project_path) |
There was a problem hiding this comment.
Preserve the --no-install escape hatch
When --no-install is used in a project with an ordinary pyproject.toml that lacks [tool.robotpy], this unconditional load raises PyprojectError before the no_install branch is reached, so deployment now aborts. Previously --no-install deliberately bypassed parsing the file—and the existing error message explicitly recommends that flag—so pre-deploy discovery needs to tolerate a missing RobotPy section or retain the bypass when installation is disabled.
Useful? React with 👍 / 👎.
|
I addressed the CI formatting failure and the review finding about preserving the |
Summary
[[tool.robotpy.deploy]]actions frompyproject.toml--no-installfor projects whosepyproject.tomlhas no RobotPy tableAddresses robotpy/mostrobotpy#257.
Verification
.venv/bin/python -m pytest— 87 passed.venv/bin/python -m mypy --show-column-numbers robotpy_installer— no issues in 21 source files.venv/bin/python -m black --check --diff .— passedEvidence
Before: the issue specification and unimplemented configuration:
After: the corrected implementation, including the review-requested
--no-installregression coverage: