release: 0.4.8#62
Merged
Merged
Conversation
AttachmentCollector previously created a fresh instance per file inside the export loop, so attachments sharing a name across different notes were not deduplicated — each file's collect() started with empty state. Hoist knownAttachments and usedNames to instance fields and route all attachment insertion through addAttachment(), which checks both the per-file 'seen' set and the cross-file 'knownAttachments' cache. The collector is now instantiated once per export (in ExportRunner.run), so uniqueName and the known-attachment map persist across all files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
PDF export
printToPDFmargins overrode the CSS@pagetop margin, zeroing it on every page after the first. (fix: PDF image spacing, page top margin, and soft line breaks #59)<br>was silently merging them). (fix: PDF image spacing, page top margin, and soft line breaks #59)Attachment handling
assetsfolder now lands under the target folder (matching PDF/Word), instead of appearing a second time at the export root. (fix: place Markdown/HTML attachment assets under target folder #60)Content consistency across formats
# Heading, it is now used as the document title and removed from the body. (fix: unify export content across formats (title, soft breaks, comments) #61)) caused images to not render in Obsidian and many viewers. (fix: unify export content across formats (title, soft breaks, comments) #61)<!-- source: ... -->comments no longer appear as literal visible text in DOCX output. (fix: unify export content across formats (title, soft breaks, comments) #61)Full changelog: 0.4.7...0.4.8